Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cannot save theme settings in 7.x - 3.0 #119

Open
maxplus opened this issue Jul 21, 2014 · 9 comments
Open

Cannot save theme settings in 7.x - 3.0 #119

maxplus opened this issue Jul 21, 2014 · 9 comments

Comments

@maxplus
Copy link

maxplus commented Jul 21, 2014

Hi,

I'm running a clean new site based on Panopoly 7.x-1.6 with Kalatheme 7.x-3.0.

I already have successfully generated a custom subtheme based on a Bootswatch theme without a problem (based on United)

But now I want to edit the theme settings through the theme appearance admin page "admin/appearance/settings" (disable logo, secondary menu,...) but I when I save this form, nothing gets saved.

On top of the "admin/appearance/settings" page of my custom Kalatheme, I keep getting the error message "If you want Kalatheme to be able to use custom Bootstrap libraries or generate subthemes automatically please properly configure your webserver."

Stange, because:

  • I have 777 permissions on both the libraries and theme folder
  • I already setup a subtheme successfully
  • I don't try to generate a new subtheme, I only want to edit some theme settings (like logo, and menu appearance)

I already cleared caches multiple times, ran Cron multiple times and my custom theme is the only active theme at the moment.

Anyone some advice about this issue?

@maxplus
Copy link
Author

maxplus commented Jul 21, 2014

Hi,

maybe nice to know for others with this problem:

I have just set my admin theme to "Seven" instead of using "Default theme"
=> now when using Seven as admin theme, the settings I have changed in the admin/appearance of my custom theme DO save, yes!

@pirog
Copy link
Contributor

pirog commented Jul 21, 2014

Just to confirm. Is the below accurate?

  • Admin theme = Seven -> Can save custom theme settings.
  • Admin theme = default theme -> Can not save custom theme settings

@pirog pirog added the 7.x-3.x label Jul 21, 2014
@pirog pirog added this to the 7.x-3.1 milestone Jul 21, 2014
@maxplus
Copy link
Author

maxplus commented Jul 21, 2014

Yes, that is correct

@maxplus
Copy link
Author

maxplus commented Jul 22, 2014

Hi,
my problems are solved by enabling the Drupal core "update manager" module.
=> the error message on top disappears
=> I can set custom theme settings
=> I can save them, when using my custom Kalatheme as admin theme!

Everything OK!

Look also at this related issue: #123

@pirog
Copy link
Contributor

pirog commented Jul 27, 2014

Very strange.... glad to see enabling updates solves the issue but we should def make sure a user can save their settings in the event that they do not want to enable updates.

@labboy0276 can you look into this and see if the status of the update module somehow prevents the form from being submitted/saved?

The logic should be that you shouldnt be able to do any subtheme related saving (in fact all subtheme options should not be exposed if you dont have updates enabled) but we should def allow the user to still save other things.

@maxplus what kinds of things were you trying to save?

@soniktrooth
Copy link
Contributor

I think this may be related:

When trying to generate a sub theme nothing happens unless kalatheme is selected as the admin theme.

@soniktrooth
Copy link
Contributor

@labboy0276 suggested we could set the admin theme to kalatheme when it gets enabled: https://www.computerminds.co.uk/articles/setting-default-theme-during-installation

@soniktrooth
Copy link
Contributor

We are already requiring the update module inside of kalatheme_backend_check() and the subtheme form generation is dependant on the return of that function. So I think that covers that part of this issue.

The comment I added is a separate issue: "When trying to generate a sub theme nothing happens unless kalatheme is selected as the admin theme."

@soniktrooth
Copy link
Contributor

soniktrooth commented May 11, 2016

"When trying to generate a sub theme nothing happens unless kalatheme is selected as the admin theme."

Confirmed this is no longer an issue: fixed as part of #215

Everything else seems to be taken care of.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

5 participants