-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
MimicExplainer does not work -- deprecate? #33
Comments
Some links that may be relevant:
There seems to be some effort going on at Microsoft for supporting SHAP - just no idea why they don't touch the main repository... |
Thanks for the links and context, it didn't occur to me to check external links. Considering that there's still some buzz around this at Microsoft, I see two options
I'm personally more for 1 (don't keep code that is not being used; else it is just a burden to maintain). Wdyt @dsgibbons @connortann ? |
I'm happy with 1. so long as we keep an open issue for implementing |
The
MimicExplainer
class currently defined inshap/explainers/mimic.py
has alot of undefined names (flagged out by ruff linting).which will result in errors if the code is executed at any point during runtime.
What I find surprising is that, the original
MimicExplainer
code was introduced by slundberg 5 years ago (!) and has practically remained unchanged since then:And yet, a quick search of issues on
slundberg/shap
on Github shows no evidence of anyone complaining / raising a bug report.From which, I conclude that really no one is using this piece of code. Shall we delete
mimic.py
, so we have less to maintain?ps. (Honestly, I have no idea how to fix even if we wanted to keep it. E.g. what is
link
that is being passed into theconvert_to_link()
function in the image above?)ps. There is also no tests for MimicExplainer currently.
The text was updated successfully, but these errors were encountered: