Skip to content
This repository has been archived by the owner on Mar 29, 2021. It is now read-only.

in-text citations don't wrap? #398

Closed
glorious1 opened this issue Dec 23, 2017 · 5 comments
Closed

in-text citations don't wrap? #398

glorious1 opened this issue Dec 23, 2017 · 5 comments
Labels

Comments

@glorious1
Copy link

glorious1 commented Dec 23, 2017

ABT Version: 4.12.0

PHP Version: 5.6

**Theme:**GeneratePress

Plugin List:

  • Very Simple Event List
  • Child Theme Configurator
  • TablePress
  • bbPress
  • Sidebar login
  • Paypal Donations

Browser: Firefox 57

Expected behavior: Citations in the text wrap.

Actual behavior: If a series of in-text citations is wider than the window, the rest is simply cut off at the window edge. If an image narrows the space available, the citation and following text jump down below the image (see attachment).

Console messages:

Note: this only appears if all other plugins are deactivated (then popups don't work). 
With others activated, this doesn't appear (and popups work).
ReferenceError: jQuery is not defined
[Learn More]
frontend.ts:1:6

screen shot 2017-12-23 at 1 04 24 pm

@dsifford
Copy link
Owner

Thanks for the report. Do you have a link to the affected page that I could check out?

@glorious1
Copy link
Author

Yes indeed. The page in the screenshot is here
http://109.73.239.174/~cookand3/forestpathology.org/air-pollutants/

and that thank you test page has it without an image:
http://109.73.239.174/~cookand3/forestpathology.org/thank-you/

Sorry to keep loading you up with issues!

@dsifford
Copy link
Owner

Ah, now I remember why I explicitly made citations non-wrapping. It becomes much more difficult to calculate where the tooltip should be placed if the citation spans more than one line because both the natural width and height of the citation are variably skewed, depending on how much the text wraps.

Obviously, this is a problem with long in-text citations. I hadn't considered that.

I'll work on improving the tooltip rendering so that text will be able to wrap naturally.

Sorry to keep loading you up with issues!

Please, keep them coming! I appreciate the feedback.

@dsifford dsifford added the bug label Dec 23, 2017
@glorious1
Copy link
Author

Ahh, I see. Well I could always switch to number citations, which would never need to wrap. They are not so common in my field, but certainly less cluttered, and with the tooltips, you don't really need the full citations.

@dsifford
Copy link
Owner

Found a much simpler fix than I originally anticipated. This should be resolved on the next update. If not, let me know.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants