Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ep/aggregate arithmetic #63

Merged
merged 13 commits into from
Mar 14, 2017
Merged

Ep/aggregate arithmetic #63

merged 13 commits into from
Mar 14, 2017

Conversation

potash
Copy link
Contributor

@potash potash commented Feb 27, 2017

Overloads the arithmetic (+,-,*,/,//) and comparison (<.<=,,==,>,>=) and boolean (&,|) operators. Handles naming of the resulting aggregates.

E.g. Aggregate("x", "sum") / Aggregate("y","count") produces the SQL line

sum(x)*1.0 / count(y) AS "x_sum/y_count"

@mbauman
Copy link
Member

mbauman commented Feb 28, 2017

Hrm, why isn't Travis running?

@mbauman mbauman closed this Feb 28, 2017
@mbauman mbauman reopened this Feb 28, 2017
@mbauman
Copy link
Member

mbauman commented Feb 28, 2017

Oh. https://www.traviscistatus.com

it's nonsensical, but it works for now.
@codecov-io
Copy link

Codecov Report

Merging #63 into master will decrease coverage by 4.46%.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage     100%   95.53%   -4.47%     
==========================================
  Files           4        4              
  Lines         222      269      +47     
==========================================
+ Hits          222      257      +35     
- Misses          0       12      +12
Impacted Files Coverage Δ
collate/spacetime.py 100% <100%> (ø)
collate/collate.py 93.71% <75.51%> (-6.29%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2565473...80b8b63. Read the comment docs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants