Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Potential rchk issue #177

Closed
chainsawriot opened this issue Jun 2, 2024 · 4 comments
Closed

Potential rchk issue #177

chainsawriot opened this issue Jun 2, 2024 · 4 comments
Labels
reprex needs a minimal reproducible example

Comments

@chainsawriot
Copy link

Thank you very much for the package. I followed your method to deal with the "Non-API calls" issue for cpp11 (#145) and uploaded the package to CRAN. And CRAN now gave me rchk issues.

I somehow feel that it is a false positive and I have tried to make duckdb run through the same rchk via the container from r-hub. But the process was killed. Maybe my computer is too weak.

My experiment with protecting the nms does seem to cancel the rchk issue ropensci/readODS#190.

@krlmlr
Copy link
Collaborator

krlmlr commented Jun 4, 2024

Thanks. Is this still an issue? I see new content in ropensci/readODS#190.

@chainsawriot
Copy link
Author

@krlmlr Yes, it is still an issue. The new content was to test and pinpoint the rchk issue to the untested path (which does not use SETLENGTH) in the truncate method of the original cpp11. And this cancels the rchk issue.

https://github.com/r-hub2/educated-yogic-starfish-rrrrrr/compare/04a1cab..2137a61

@krlmlr
Copy link
Collaborator

krlmlr commented Aug 17, 2024

I don't follow. How can I help, is there anything we need to fix here? As far as I can tell, duckdb is fine.

@krlmlr krlmlr added the reprex needs a minimal reproducible example label Aug 17, 2024
@chainsawriot
Copy link
Author

According to the discussion here, this can be a false positive of rhck. If duckdb is fine, then I think I can close this.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
reprex needs a minimal reproducible example
Projects
None yet
Development

No branches or pull requests

2 participants