Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

Always raise a more specific exception than Exception #95

Open
richcooper95 opened this issue Feb 2, 2022 · 0 comments
Open

Always raise a more specific exception than Exception #95

richcooper95 opened this issue Feb 2, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@richcooper95
Copy link

Describe the bug
In some places, Exception is raised - this isn't good practice as it makes it almost impossible for the users of the library to catch this specific exception without hiding bugs - see discussion here.

To Reproduce
n/a

Expected behavior
It’s much better to define a custom Exception class, or use one of the built-ins (e.g. RuntimeError).

Examples around here - in this case, InvalidResponseError might be a better exception type.

System (please complete the following information):
n/a

Additional context
n/a

@richcooper95 richcooper95 added the bug Something isn't working label Feb 2, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant