Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add typing to features and make data types consistent #56

Closed
duyminh1998 opened this issue Dec 5, 2023 · 0 comments
Closed

Add typing to features and make data types consistent #56

duyminh1998 opened this issue Dec 5, 2023 · 0 comments
Labels
Milestone

Comments

@duyminh1998
Copy link
Owner

We should

make the data types that are exported in the features object consistent (from the Lua library that outputs the observations to xml to the FeaturesFromSteam class that parses it)

Because

currently we do not have a consistent agreement of the data types of each field (e.g. an aircraft's heading is a string rather than a float)

Complexity

Easy to medium.

Definition of Done

  1. Change the namedtuple objects in features.py to NamedTuple from typing to add typing.
  2. Make data types consistent for fields in features.py and pycmo_lib.lua and fix any tests or demos that might be broke.
  3. Potentially change SteamClientProps from a data class to a NamedTuple class.
@duyminh1998 duyminh1998 added this to the 1.4.0 milestone Dec 5, 2023
@duyminh1998 duyminh1998 moved this to Backlog in @duyminh1998's pyCMO Dec 5, 2023
@duyminh1998 duyminh1998 moved this from Backlog to Started in @duyminh1998's pyCMO Dec 5, 2023
@github-project-automation github-project-automation bot moved this from Started to Releasable in @duyminh1998's pyCMO Dec 9, 2023
@duyminh1998 duyminh1998 moved this from Releasable to Delivered in @duyminh1998's pyCMO Dec 12, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
Status: Delivered
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant