Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Don't reset config.json on build version changes #141

Closed
stamoun opened this issue Sep 13, 2021 · 1 comment
Closed

Don't reset config.json on build version changes #141

stamoun opened this issue Sep 13, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@stamoun
Copy link
Collaborator

stamoun commented Sep 13, 2021

Lofi is using a classic Major.Minor.Build version labeling scheme. Currently, as soon as the code detects a version difference, it nukes the whole version.

The idea would be to keep the settings intact whenever a build version changes or, even a minor version change (depending on the change...?).

For major versions, there should be a migration of the settings (to add new stuff and remove any obsolete ones).

The main goal would be to prevent having the user to lose his credentials and settings every time we change the version number.

@stamoun stamoun added the enhancement New feature or request label Sep 13, 2021
@stamoun
Copy link
Collaborator Author

stamoun commented Apr 29, 2022

Use electron-config migrations instead of flushing everything...

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant