Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Do not use copied autogenerated files for x/rollapp #1078

Closed
keruch opened this issue Sep 18, 2024 · 0 comments · Fixed by #1079
Closed

Do not use copied autogenerated files for x/rollapp #1078

keruch opened this issue Sep 18, 2024 · 0 comments · Fixed by #1079
Assignees

Comments

@keruch
Copy link
Contributor

keruch commented Sep 18, 2024

Dymint imported the Hub previously, but now Cosmos versions are different as well as other deps, so direct import doesn't work currently. As a workaround, the autogenerated proto contracts were copied from the Hub to Dymint. Copying autogenerated files is not safe (it can lead to dependencies mismatch), it's impossible to find what was the original proto for these files, and it's extremely inobvious how to add new fields to such proto contracts (apparently find a suitable generator, generate files using it, and then manually copy them?).

This PR moves x/rollapp proto contracts from the Hub to Dymint, so the files are generated directly in the Dymint repo with its own proto generator.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant