-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Handling locked questionnaires #1484
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardebeling
approved these changes
Jun 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test would be nice
janno42
force-pushed
the
locked_questionnaires
branch
from
June 20, 2020 09:15
9f1d611
to
b6115b8
Compare
pixunil
reviewed
Jun 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solution looks simple and nice! I added some comments and my test.
janno42
force-pushed
the
locked_questionnaires
branch
from
June 20, 2020 14:25
735767d
to
aac86ed
Compare
janno42
commented
Jun 20, 2020
janno42
force-pushed
the
locked_questionnaires
branch
from
June 20, 2020 14:43
aac86ed
to
ffc4ad1
Compare
janno42
force-pushed
the
locked_questionnaires
branch
2 times, most recently
from
June 22, 2020 17:30
96487c0
to
eac14cb
Compare
pixunil
approved these changes
Jun 22, 2020
janno42
force-pushed
the
locked_questionnaires
branch
from
June 22, 2020 17:37
eac14cb
to
26c82a7
Compare
janno42
force-pushed
the
locked_questionnaires
branch
from
June 22, 2020 17:37
26c82a7
to
56c307a
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1479
This fixes the problems of handling locked questionnaires in editor forms.
What kinds of tests do we need? @pixunil do you want to add yours?