Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Handling locked questionnaires #1484

Merged
merged 5 commits into from
Jun 22, 2020

Conversation

janno42
Copy link
Member

@janno42 janno42 commented Jun 19, 2020

fixes #1479

This fixes the problems of handling locked questionnaires in editor forms.
What kinds of tests do we need? @pixunil do you want to add yours?

Copy link
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test would be nice

Copy link
Contributor

@pixunil pixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solution looks simple and nice! I added some comments and my test.

evap/contributor/forms.py Outdated Show resolved Hide resolved
evap/contributor/forms.py Outdated Show resolved Hide resolved
evap/contributor/tests/test_views.py Outdated Show resolved Hide resolved
evap/contributor/tests/test_views.py Outdated Show resolved Hide resolved
evap/contributor/tests/test_views.py Outdated Show resolved Hide resolved
evap/contributor/tests/test_views.py Outdated Show resolved Hide resolved
@janno42 janno42 force-pushed the locked_questionnaires branch 2 times, most recently from 96487c0 to eac14cb Compare June 22, 2020 17:30
@janno42 janno42 merged commit b6b9385 into e-valuation:master Jun 22, 2020
@janno42 janno42 deleted the locked_questionnaires branch June 22, 2020 17:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Locked questionnaires failing in editor form
3 participants