-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Out of date dependencies #27
Comments
If you submit a PR, I will try to get it merged. However, I am not a dev on this project, so we will need to find somebody to run the tests. @bounav I assume you have that ability, is that correct? In the absence of somebody to check that your PR doesn't break anything, we may want to merge anyway. |
Three out of these four updates span breaking changes. They are almost certain to cause breakage. Unless somebody (@bounav?) is offering to fix the breakage, we should archive this repo. |
After several tries to get this updated, I think it is time to archive. |
Hi @lucasgonze just saw your replies.
Can you elaborate? In my PR #28 I included minor code changes needed to run with the updated dependencies. |
I'm closing this issue as PR #30 updated dependencies. |
Hello,
Would the maintainers be open to accept a
pull request
that updating the dependencies of this project? I'd be happy to submit one.Proposed change:
The main driver for this is that
YamlDotNet
is very out of date and the current nuget package referenced doesn't has itspublicKeyToken
assembly property to set and this is causing FileNotFound exceptions if you happen to also reference a more recent version of the package (that will have apublicKeyTokenVaue
.The referenced version of
Newtonsoft.Json
and log4net have some known vulnerabilities.The other updates are just general housekeeping.
The text was updated successfully, but these errors were encountered: