Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Small suggestion about Batteries mod and Lethalprogression :) #2

Open
Uniteria opened this issue Feb 12, 2024 · 2 comments
Open

Small suggestion about Batteries mod and Lethalprogression :) #2

Uniteria opened this issue Feb 12, 2024 · 2 comments

Comments

@Uniteria
Copy link

Uniteria commented Feb 12, 2024

Hey! I'm using your mod on my server and kinda love it. The thing is, we also use Lethalprogression, so our flashlights have slightly increased lifespan. Question is: Is it possible to make it work together? Like when you have 200% flashlight, and battery in config is set up to 2 instead of 1, it should charge flashlight to 200%? If so, then i'll be so glad since it open new mechanic to the game with batteries as main source of power rather than ship charger.

I've tested it and battery only charge up to 100% (5 minutes) even when set to 2, 5, 10 etc.

@eXish
Copy link
Owner

eXish commented Feb 12, 2024

The mod currently assumes that the lifespan of all charged weapons have the vanilla maximum. I'm not sure if I missed a variable that would actually tell me what the maximum for an item is but I can investigate to see if I can find one to make this work. Even if I can't I can always add in like a plugin check or something to see if lethalprogression is present and then have to code execute based on that. Thanks for the report!

@Uniteria
Copy link
Author

The mod currently assumes that the lifespan of all charged weapons have the vanilla maximum. I'm not sure if I missed a variable that would actually tell me what the maximum for an item is but I can investigate to see if I can find one to make this work. Even if I can't I can always add in like a plugin check or something to see if lethalprogression is present and then have to code execute based on that. Thanks for the report!

That's awesome! Thanks a lot :) Will look forward into it when fix appears :D

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants