Invalid pod-styles.sass with recent versions of sass

[richard-viney]

Encountered the following error while looking at moving a project from BEM+Sass to ember-component-css:

Sass Syntax Error (SassCompiler) in /app/styles/pod-styles.sass:1:58

Error: semicolons aren't allowed in the indented syntax.
@import "styles/component-styles/animation-selector.sass";
                                                         ^
  tmp/sass_compiler-input_base_path-BJ832gH0.tmp/app/styles/pod-styles.sass 1:58  root stylesheet
  tmp/sass_compiler-input_base_path-BJ832gH0.tmp/app/styles/app.scss 1:9          root stylesheet

Stack Trace and Error Report: /tmp/error.dump.3a37c6f4d516a6d17ffacfdf0420b591.log

Generated pod-styles.sass:

$ cat tmp/sass_compiler-input_base_path-BJ832gH0.tmp/app/styles/pod-styles.sass

@import "styles/component-styles/animation-selector.sass";

Seems as though the generated pod-styles.sass shouldn't be including semicolons like it's currently doing?

Relevant versions:

ember-component-css: 0.6.5
ember-source: 3.4.5
ember-cli: 3.4.3
ember-cli-sass: 8.0.1
yarn sass --version: 1.14.0 compiled with dart2js 2.0.0

[webark]

@richard-viney i’ll try to look into this next week. Please feel free to ping me here or in discord if i do not.

[luketheobscure]

Same issue here, except running sass 1.14.1.

I tested all the way back to ember-component-css v0.5.0 and I get the same issue. Must be a problem with newer versions of ember-cli-sass.

[luketheobscure]

Dropping down to ember-cli-sass v7.2.0 fixes the issue.

[webark]

ya.. the you used to be able to do semi colons in sass.. now you can’t..

ember-component-css/lib/colocate-namespace.js

Line 79 in 7d92100

return new Replace(styleManifest, {

this little part from the new way of doing this needs to be brought over.

[richard-viney]

Great, let me know if there's anything I can do.

[richard-viney]

Btw when you mentioned the 'new way', is that on a working branch somewhere?

[webark]

you can look at PR #300
Sorry.. getting ready to go on praternity leave in the next few weeks, so things are busy at work and life right now.

[anulman]

@webark Catching up on all the threads and just saw this. Congratulations!

[richard-viney]

Great, looks like this has been addressed in 0.6.7. Shall we close this issue?

[anulman]

Omg is it? I am so excited to upgrade :)

[webark]

this should be fixed in 0.6.7.