Releases should not depend on insecure or untrusted code

[JLLeitschuh]

CWE-829: Inclusion of Functionality from Untrusted Control Sphere

The build files indicate that this project is resolving dependencies over HTTP instead of HTTPS. Any of these artifacts could have been MITM to maliciously compromise them and infect the build artifacts that were produced. Additionally, if any of these JARs or other dependencies were compromised, any developers using these could continue to be infected past updating to fix this.

This vulnerability has a CVSS v3.0 Base Score of 8.1/10
https://nvd.nist.gov/vuln-metrics/cvss/v3-calculator?vector=AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:H

This isn't just theoretical

POC code exists already to maliciously compromise a JAR file inflight.
See:

• https://max.computer/blog/how-to-take-over-the-computer-of-any-java-or-clojure-or-scala-developer/
• https://github.com/mveytsman/dilettante

MITM Attacks Increasingly Common:

See:

• https://serverfault.com/a/153065
• https://security.stackexchange.com/a/12050

Source Locations:

Download of Eclipse SDK:

• https://github.com/eclipse/buildship/blob/3348ffc10e50963c67110d34374be5f0abebb4af/build.gradle#L433-L443
• https://github.com/eclipse/buildship/blob/4ee595bd33bd84cb788debc15900a98af6f05c59/buildSrc/src/main/groovy/eclipsebuild/Constants.groovy#L99

Eclipse SDK has no checksum verification:

• https://github.com/eclipse/buildship/blob/4ee595bd33bd84cb788debc15900a98af6f05c59/buildSrc/src/main/groovy/eclipsebuild/DownloadEclipseSdkTask.groovy#L21-L60

Download of Gradle:

• https://github.com/eclipse/buildship/blob/4ee595bd33bd84cb788debc15900a98af6f05c59/org.eclipse.buildship.core.test/src/main/groovy/org/eclipse/buildship/core/internal/workspace/InitializeNewProjectOperationTest.groovy#L34

[donat]

Thanks for reporting this. I'll try to fix this.

[JLLeitschuh]

Heads up, I plan to publish a public disclosure about this industry-wide vulnerability on June 10th, 2019.

[JLLeitschuh]

Ping!

[donat]

I'll take care of this before the deadline.

[JLLeitschuh]

@donat This will also need a CVE issued. That can be done through @waynebeaton as the Eclipse Foundation is a CNA.

See this format as an example:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=546622

[donat]

I've implemented the fix for this issue. See the PR ☝️.
@JLLeitschuh I trust you handle the CVE report.

[JLLeitschuh]

@donat You need to file for the CVE with @waynebeaton using the Eclipse bug tracker. Since the Eclipse organization is a CNA, the Eclipse security team does the reporting. You or some other contributor needs to be the one to ask @waynebeaton to do the filing.

See this format as an example:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=546622

[donat]

CVE request submitted: https://bugs.eclipse.org/bugs/show_bug.cgi?id=547734