Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move the time-axis to its own library #32

Open
3 tasks
tahini opened this issue May 25, 2020 · 2 comments
Open
3 tasks

Move the time-axis to its own library #32

tahini opened this issue May 25, 2020 · 2 comments
Labels
help wanted Extra attention is needed Theia UI frontend timeline-chart Involves changes in the timeline chart project: https://github.com/theia-ide/timeline-chart
Milestone

Comments

@tahini
Copy link
Contributor

tahini commented May 25, 2020

The time-axis used is part of the timeline-chart library. It should be moved in a separate library so that it can be reused (eg for XY charts) and updated separately. The time-axis is the basis for navigation: zoom in/out, show the current time range.

  • There is a unit controller "TimeGraphUnitController in the timeline-chart library that control the "time" and a "TimeAxisComponent" that use the unit controller to draw the axis
  • Maybe everything can stay in the timeline-chart library or can be split into different components that can be added as dependencies
  • The time-axis also has a visual representation. Be creative ;-) Lttng-scope had an interesting approach
@tahini tahini added help wanted Extra attention is needed timeline-chart Involves changes in the timeline chart project: https://github.com/theia-ide/timeline-chart Theia UI frontend labels May 25, 2020
@tahini tahini added this to the First MVP milestone May 25, 2020
@ebugden
Copy link
Contributor

ebugden commented Mar 26, 2021

Fixed by theia-ide/timeline-chart

arfio: it is in the package.json of the theia-trace-extension and is built separately so I guess the issue can be closed

@ebugden ebugden closed this as completed Mar 26, 2021
@bhufmann bhufmann reopened this Mar 30, 2021
@bhufmann bhufmann changed the title Move the timeline to its own library Move the time axis to its own library Mar 30, 2021
@bhufmann bhufmann changed the title Move the time axis to its own library Move the time-axis to its own library Mar 30, 2021
@bhufmann
Copy link
Collaborator

I re-opened this because this issue is about the time-axis of the timeline-chart library and not about the timeline-chart library itself. I also updated the description for clarification reason.

@ebugden ebugden modified the milestones: MVP, 1.0 Sep 30, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
help wanted Extra attention is needed Theia UI frontend timeline-chart Involves changes in the timeline chart project: https://github.com/theia-ide/timeline-chart
Projects
None yet
Development

No branches or pull requests

3 participants