Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Resources Status filler row height too big #802

Open
bhufmann opened this issue Aug 3, 2022 · 2 comments
Open

Resources Status filler row height too big #802

bhufmann opened this issue Aug 3, 2022 · 2 comments
Labels
Theia UI frontend timeline-chart Involves changes in the timeline chart project: https://github.com/theia-ide/timeline-chart Trace Server Involve changes in the trace server itself (in the incubator source code) UX User experience improvement

Comments

@bhufmann
Copy link
Collaborator

bhufmann commented Aug 3, 2022

The Resources Status view of the Trace Compass server has a filler row between the CPUs to visually separate the CPUs. However, the filler row is drawn with the same height as a regular row which wastes vertical space and doesn't have a great UX.

To support this independently from the trace server and view, such filler rows need to be styled through the data provider TSP API.

Theia Trace Extension with Trace Compass server:
image

In Eclipse Trace Compass it looks like this:
image

@bhufmann bhufmann added Trace Server Involve changes in the trace server itself (in the incubator source code) UX User experience improvement timeline-chart Involves changes in the timeline chart project: https://github.com/theia-ide/timeline-chart Theia UI frontend labels Aug 3, 2022
@williamsyang-work
Copy link
Contributor

williamsyang-work commented Jan 17, 2023

There is no explicit identifier for the "filler rows", but they all come in with an empty string "" as their name. Filler rows can be identified height set through the Row Style Provider easily. But we can move forward by identifying filler rows either by:

  1. Identify "filler rows" by their empty string name "".
  • Simple fix, can be contained to this repository.
  1. Add an explicit tag for "filter rows" on the back end.
  • More complicated, but cleaner and less 'hacky'.

@bhufmann
Copy link
Collaborator Author

bhufmann commented Jan 17, 2023

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Theia UI frontend timeline-chart Involves changes in the timeline chart project: https://github.com/theia-ide/timeline-chart Trace Server Involve changes in the trace server itself (in the incubator source code) UX User experience improvement
Projects
None yet
Development

No branches or pull requests

3 participants