Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove XML header from beans.xml files #663

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

brideck
Copy link
Contributor

@brideck brideck commented Mar 15, 2021

Signed-off-by: Brian Decker bmdecker@us.ibm.com

PR #635 included XML headers in the beans.xml files, which the parser in Weld did not end up liking. Quick fix to remove them.

CC @gurunrao @scottmarlow

Signed-off-by: Brian Decker <bmdecker@us.ibm.com>
@scottmarlow
Copy link
Contributor

scottmarlow commented Mar 15, 2021

This looks fine, I missed that the <?xml version="1.0" encoding="UTF-8"?> was not on the first line which is easy to overlook.

@scottmarlow scottmarlow merged commit f23e478 into jakartaee:master Mar 15, 2021
@gurunrao
Copy link
Contributor

CI run for JAXRS tests with Full Profile GF 6.0 + JDK 8 and PR branch is passing.
CI run can be found here - https://ci.eclipse.org/jakartaee-tck/job/guru/job/jakartaeetck-gtest/job/RemoveXMLHeaders/2/testReport/
@brideck Thanks for the Fix.
CC @scottmarlow

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants