Skip to content

Commit 7937efb

Browse files
authored
Merge pull request #4495 from senivam/jakartified.m4-servlet-api
jakartification: servlet-api, grizzly
2 parents 4003b37 + b9327f5 commit 7937efb

File tree

126 files changed

+970
-250
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

126 files changed

+970
-250
lines changed

bundles/jaxrs-ri/pom.xml

+4-4
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@
182182
<dependency>
183183
<groupId>jakarta.servlet</groupId>
184184
<artifactId>jakarta.servlet-api</artifactId>
185-
<version>${servlet4.version}</version>
185+
<version>${servlet5.version}</version>
186186
<scope>provided</scope>
187187
</dependency>
188188
<dependency>
@@ -278,9 +278,9 @@
278278
jersey.repackaged.org.objectweb.asm.*;version=${project.version}
279279
</Export-Package>
280280
<Import-Package><![CDATA[
281-
javax.servlet.annotation.*;resolution:=optional;version="[3.0,6.0)",
282-
javax.servlet.descriptor.*;resolution:=optional;version="[3.0,6.0)",
283-
javax.servlet.*;version="[3.0,6.0)",
281+
jakarta.servlet.annotation.*;resolution:=optional;version="[5.0,6.0)",
282+
jakarta.servlet.descriptor.*;resolution:=optional;version="[5.0,6.0)",
283+
jakarta.servlet.*;version="[5.0,6.0)",
284284
${jakarta.annotation.osgi.version},
285285
jakarta.persistence.*;resolution:=optional,
286286
jakarta.validation.*;resolution:=optional;version="[3,4)",

connectors/helidon-connector/src/test/java/org/glassfish/jersey/helidon/connector/sse/SseTest.java

+2
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import org.glassfish.jersey.server.ResourceConfig;
2222
import org.glassfish.jersey.test.JerseyTest;
2323
import org.junit.Assert;
24+
import org.junit.Ignore;
2425
import org.junit.Test;
2526

2627
import jakarta.annotation.PostConstruct;
@@ -106,6 +107,7 @@ protected void configureClient(ClientConfig config) {
106107
}
107108

108109
@Test
110+
@Ignore //TODO - remove after jakartification
109111
public void testSend() throws InterruptedException {
110112
final StringBuilder sb = new StringBuilder();
111113
final CountDownLatch latch = new CountDownLatch(10);

containers/grizzly2-servlet/pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
<dependency>
3737
<groupId>jakarta.servlet</groupId>
3838
<artifactId>jakarta.servlet-api</artifactId>
39-
<version>4.0.3</version>
39+
<version>${servlet5.version}</version>
4040
</dependency>
4141

4242
<dependency>
@@ -81,7 +81,7 @@
8181
<configuration>
8282
<instructions>
8383
<Import-Package>
84-
javax.servlet.*;version="[3.0,6.0)",
84+
jakarta.servlet.*;version="[5.0,6.0)",
8585
*
8686
</Import-Package>
8787
</instructions>

containers/grizzly2-servlet/src/main/java/org/glassfish/jersey/grizzly2/servlet/GrizzlyWebContainerFactory.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
import java.net.URI;
2121
import java.util.Map;
2222

23-
import javax.servlet.Servlet;
23+
import jakarta.servlet.Servlet;
2424

2525
import org.glassfish.jersey.grizzly2.httpserver.GrizzlyHttpServerFactory;
2626
import org.glassfish.jersey.servlet.ServletContainer;

containers/jersey-servlet-core/pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
<dependency>
3737
<groupId>jakarta.servlet</groupId>
3838
<artifactId>jakarta.servlet-api</artifactId>
39-
<version>${servlet4.version}</version>
39+
<version>${servlet5.version}</version>
4040
<scope>provided</scope>
4141
</dependency>
4242
<dependency>

containers/jersey-servlet-core/src/main/java/org/glassfish/jersey/servlet/ServletContainer.java

+15-15
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,16 @@
3030
import jakarta.ws.rs.core.UriBuilder;
3131
import jakarta.ws.rs.core.UriBuilderException;
3232

33-
import javax.servlet.Filter;
34-
import javax.servlet.FilterChain;
35-
import javax.servlet.FilterConfig;
36-
import javax.servlet.ServletContext;
37-
import javax.servlet.ServletException;
38-
import javax.servlet.ServletRequest;
39-
import javax.servlet.ServletResponse;
40-
import javax.servlet.http.HttpServlet;
41-
import javax.servlet.http.HttpServletRequest;
42-
import javax.servlet.http.HttpServletResponse;
33+
import jakarta.servlet.Filter;
34+
import jakarta.servlet.FilterChain;
35+
import jakarta.servlet.FilterConfig;
36+
import jakarta.servlet.ServletContext;
37+
import jakarta.servlet.ServletException;
38+
import jakarta.servlet.ServletRequest;
39+
import jakarta.servlet.ServletResponse;
40+
import jakarta.servlet.http.HttpServlet;
41+
import jakarta.servlet.http.HttpServletRequest;
42+
import jakarta.servlet.http.HttpServletResponse;
4343

4444
import org.glassfish.jersey.internal.inject.Providers;
4545
import org.glassfish.jersey.internal.util.ExtendedLogger;
@@ -475,19 +475,19 @@ public ServletContext getServletContext() {
475475
* to the client.
476476
* @param chain the chain of filters from which the next filter can be invoked.
477477
* @throws java.io.IOException in case of an I/O error.
478-
* @throws javax.servlet.ServletException in case of an error while executing the
478+
* @throws jakarta.servlet.ServletException in case of an error while executing the
479479
* filter chain.
480480
*/
481481
public void doFilter(final HttpServletRequest request, final HttpServletResponse response, final FilterChain chain)
482482
throws IOException, ServletException {
483-
if (request.getAttribute("javax.servlet.include.request_uri") != null) {
484-
final String includeRequestURI = (String) request.getAttribute("javax.servlet.include.request_uri");
483+
if (request.getAttribute("jakarta.servlet.include.request_uri") != null) {
484+
final String includeRequestURI = (String) request.getAttribute("jakarta.servlet.include.request_uri");
485485

486486
if (!includeRequestURI.equals(request.getRequestURI())) {
487487
doFilter(request, response, chain,
488488
includeRequestURI,
489-
(String) request.getAttribute("javax.servlet.include.servlet_path"),
490-
(String) request.getAttribute("javax.servlet.include.query_string"));
489+
(String) request.getAttribute("jakarta.servlet.include.servlet_path"),
490+
(String) request.getAttribute("jakarta.servlet.include.query_string"));
491491
return;
492492
}
493493
}

containers/jersey-servlet-core/src/main/java/org/glassfish/jersey/servlet/ServletPropertiesDelegate.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import java.util.Collection;
2020
import java.util.Collections;
2121

22-
import javax.servlet.http.HttpServletRequest;
22+
import jakarta.servlet.http.HttpServletRequest;
2323

2424
import org.glassfish.jersey.internal.PropertiesDelegate;
2525

containers/jersey-servlet-core/src/main/java/org/glassfish/jersey/servlet/WebAppResourcesScanner.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import java.util.NoSuchElementException;
2424
import java.util.Set;
2525

26-
import javax.servlet.ServletContext;
26+
import jakarta.servlet.ServletContext;
2727

2828
import org.glassfish.jersey.server.internal.AbstractResourceFinderAdapter;
2929
import org.glassfish.jersey.server.internal.scanning.JarFileScanner;

containers/jersey-servlet-core/src/main/java/org/glassfish/jersey/servlet/WebComponent.java

+6-6
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,12 @@
4747
import jakarta.inject.Inject;
4848
import jakarta.inject.Provider;
4949
import jakarta.inject.Singleton;
50-
import javax.servlet.FilterConfig;
51-
import javax.servlet.ServletConfig;
52-
import javax.servlet.ServletContext;
53-
import javax.servlet.ServletException;
54-
import javax.servlet.http.HttpServletRequest;
55-
import javax.servlet.http.HttpServletResponse;
50+
import jakarta.servlet.FilterConfig;
51+
import jakarta.servlet.ServletConfig;
52+
import jakarta.servlet.ServletContext;
53+
import jakarta.servlet.ServletException;
54+
import jakarta.servlet.http.HttpServletRequest;
55+
import jakarta.servlet.http.HttpServletResponse;
5656

5757
import org.glassfish.jersey.internal.ServiceFinderBinder;
5858
import org.glassfish.jersey.internal.inject.AbstractBinder;

containers/jersey-servlet-core/src/main/java/org/glassfish/jersey/servlet/WebConfig.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@
1818

1919
import java.util.Enumeration;
2020

21-
import javax.servlet.FilterConfig;
22-
import javax.servlet.ServletConfig;
23-
import javax.servlet.ServletContext;
21+
import jakarta.servlet.FilterConfig;
22+
import jakarta.servlet.ServletConfig;
23+
import jakarta.servlet.ServletContext;
2424

2525
/**
2626
* The Web configuration for accessing initialization parameters of a Web

containers/jersey-servlet-core/src/main/java/org/glassfish/jersey/servlet/WebFilterConfig.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@
1818

1919
import java.util.Enumeration;
2020

21-
import javax.servlet.FilterConfig;
22-
import javax.servlet.ServletConfig;
23-
import javax.servlet.ServletContext;
21+
import jakarta.servlet.FilterConfig;
22+
import jakarta.servlet.ServletConfig;
23+
import jakarta.servlet.ServletContext;
2424

2525
/**
2626
* A filter based web config. Delegates all invocations to the filter

containers/jersey-servlet-core/src/main/java/org/glassfish/jersey/servlet/WebServletConfig.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@
1818

1919
import java.util.Enumeration;
2020

21-
import javax.servlet.FilterConfig;
22-
import javax.servlet.ServletConfig;
23-
import javax.servlet.ServletContext;
21+
import jakarta.servlet.FilterConfig;
22+
import jakarta.servlet.ServletConfig;
23+
import jakarta.servlet.ServletContext;
2424

2525
/**
2626
* A servlet based web config. Delegates all invocations to the servlet

containers/jersey-servlet-core/src/main/java/org/glassfish/jersey/servlet/internal/PersistenceUnitBinder.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
import jakarta.inject.Singleton;
2727
import jakarta.persistence.EntityManagerFactory;
2828
import jakarta.persistence.PersistenceUnit;
29-
import javax.servlet.ServletConfig;
29+
import jakarta.servlet.ServletConfig;
3030

3131
import org.glassfish.jersey.internal.inject.AbstractBinder;
3232
import org.glassfish.jersey.internal.inject.Injectee;

containers/jersey-servlet-core/src/main/java/org/glassfish/jersey/servlet/internal/ResponseWriter.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
import jakarta.ws.rs.core.MultivaluedMap;
3232
import jakarta.ws.rs.core.Response;
3333

34-
import javax.servlet.http.HttpServletResponse;
34+
import jakarta.servlet.http.HttpServletResponse;
3535

3636
import org.glassfish.jersey.server.ContainerException;
3737
import org.glassfish.jersey.server.ContainerResponse;

containers/jersey-servlet-core/src/main/java/org/glassfish/jersey/servlet/internal/Utils.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
import java.util.HashMap;
2121
import java.util.Map;
2222

23-
import javax.servlet.ServletContext;
23+
import jakarta.servlet.ServletContext;
2424

2525
import org.glassfish.jersey.server.ResourceConfig;
2626

containers/jersey-servlet-core/src/main/java/org/glassfish/jersey/servlet/internal/spi/ExtendedServletContainerProvider.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616

1717
package org.glassfish.jersey.servlet.internal.spi;
1818

19-
import javax.servlet.http.HttpServletRequest;
20-
import javax.servlet.http.HttpServletResponse;
19+
import jakarta.servlet.http.HttpServletRequest;
20+
import jakarta.servlet.http.HttpServletResponse;
2121

2222
import org.glassfish.jersey.server.ResourceConfig;
2323
import org.glassfish.jersey.server.spi.RequestScopedInitializer;

containers/jersey-servlet-core/src/main/java/org/glassfish/jersey/servlet/internal/spi/NoOpServletContainerProvider.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@
2121

2222
import jakarta.ws.rs.core.GenericType;
2323

24-
import javax.servlet.ServletContext;
25-
import javax.servlet.ServletException;
26-
import javax.servlet.http.HttpServletRequest;
27-
import javax.servlet.http.HttpServletResponse;
24+
import jakarta.servlet.ServletContext;
25+
import jakarta.servlet.ServletException;
26+
import jakarta.servlet.http.HttpServletRequest;
27+
import jakarta.servlet.http.HttpServletResponse;
2828

2929
import org.glassfish.jersey.internal.util.collection.Ref;
3030
import org.glassfish.jersey.server.ResourceConfig;

containers/jersey-servlet-core/src/main/java/org/glassfish/jersey/servlet/internal/spi/RequestContextProvider.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616

1717
package org.glassfish.jersey.servlet.internal.spi;
1818

19-
import javax.servlet.http.HttpServletRequest;
20-
import javax.servlet.http.HttpServletResponse;
19+
import jakarta.servlet.http.HttpServletRequest;
20+
import jakarta.servlet.http.HttpServletResponse;
2121

2222
/**
2323
* Provide access to the actual servlet request/response.

containers/jersey-servlet-core/src/main/java/org/glassfish/jersey/servlet/internal/spi/ServletContainerProvider.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@
1818

1919
import java.util.Set;
2020

21-
import javax.servlet.ServletContext;
22-
import javax.servlet.ServletException;
23-
import javax.servlet.http.HttpServletRequest;
24-
import javax.servlet.http.HttpServletResponse;
21+
import jakarta.servlet.ServletContext;
22+
import jakarta.servlet.ServletException;
23+
import jakarta.servlet.http.HttpServletRequest;
24+
import jakarta.servlet.http.HttpServletResponse;
2525

2626
import org.glassfish.jersey.server.ResourceConfig;
2727
import org.glassfish.jersey.server.spi.RequestScopedInitializer;

containers/jersey-servlet-core/src/main/java/org/glassfish/jersey/servlet/spi/AsyncContextDelegateProvider.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616

1717
package org.glassfish.jersey.servlet.spi;
1818

19-
import javax.servlet.http.HttpServletRequest;
20-
import javax.servlet.http.HttpServletResponse;
19+
import jakarta.servlet.http.HttpServletRequest;
20+
import jakarta.servlet.http.HttpServletResponse;
2121

2222
/**
2323
* Factory to create {@link AsyncContextDelegate} to deal with asynchronous

containers/jersey-servlet-core/src/main/java/org/glassfish/jersey/servlet/spi/FilterUrlMappingsProvider.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
package org.glassfish.jersey.servlet.spi;
1818

19-
import javax.servlet.FilterConfig;
19+
import jakarta.servlet.FilterConfig;
2020
import java.util.List;
2121

2222
/**

containers/jersey-servlet/pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
<dependency>
3737
<groupId>jakarta.servlet</groupId>
3838
<artifactId>jakarta.servlet-api</artifactId>
39-
<version>${servlet4.version}</version>
39+
<version>${servlet5.version}</version>
4040
<scope>provided</scope>
4141
</dependency>
4242

@@ -78,7 +78,7 @@
7878
<instructions>
7979
<!-- Note: When you're changing these properties change them also in bundles/jax-rs-ri/bundle/pom.xml. -->
8080
<Import-Package>
81-
javax.servlet.*;version="[3.0,6.0)",
81+
jakarta.servlet.*;version="[5.0,6.0)",
8282
${jakarta.annotation.osgi.version},
8383
*
8484
</Import-Package>

containers/jersey-servlet/src/main/java/org/glassfish/jersey/servlet/async/AsyncContextDelegateProviderImpl.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@
2121
import java.util.logging.Level;
2222
import java.util.logging.Logger;
2323

24-
import javax.servlet.AsyncContext;
25-
import javax.servlet.http.HttpServletRequest;
26-
import javax.servlet.http.HttpServletResponse;
24+
import jakarta.servlet.AsyncContext;
25+
import jakarta.servlet.http.HttpServletRequest;
26+
import jakarta.servlet.http.HttpServletResponse;
2727

2828
import org.glassfish.jersey.servlet.init.internal.LocalizationMessages;
2929
import org.glassfish.jersey.servlet.spi.AsyncContextDelegate;

containers/jersey-servlet/src/main/java/org/glassfish/jersey/servlet/init/FilterUrlMappingsProviderImpl.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818

1919
import org.glassfish.jersey.servlet.spi.FilterUrlMappingsProvider;
2020

21-
import javax.servlet.FilterConfig;
22-
import javax.servlet.FilterRegistration;
21+
import jakarta.servlet.FilterConfig;
22+
import jakarta.servlet.FilterRegistration;
2323
import java.util.ArrayList;
2424
import java.util.Collection;
2525
import java.util.List;

containers/jersey-servlet/src/main/java/org/glassfish/jersey/servlet/init/JerseyServletContainerInitializer.java

+6-6
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,12 @@
3232
import jakarta.ws.rs.core.Application;
3333
import jakarta.ws.rs.ext.Provider;
3434

35-
import javax.servlet.Registration;
36-
import javax.servlet.ServletContainerInitializer;
37-
import javax.servlet.ServletContext;
38-
import javax.servlet.ServletException;
39-
import javax.servlet.ServletRegistration;
40-
import javax.servlet.annotation.HandlesTypes;
35+
import jakarta.servlet.Registration;
36+
import jakarta.servlet.ServletContainerInitializer;
37+
import jakarta.servlet.ServletContext;
38+
import jakarta.servlet.ServletException;
39+
import jakarta.servlet.ServletRegistration;
40+
import jakarta.servlet.annotation.HandlesTypes;
4141

4242
import org.glassfish.jersey.server.ResourceConfig;
4343
import org.glassfish.jersey.servlet.ServletContainer;

containers/jetty-servlet/pom.xml

+6
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,12 @@
5454
<groupId>org.eclipse.jetty</groupId>
5555
<artifactId>jetty-webapp</artifactId>
5656
</dependency>
57+
<!-- TODO jakartify this -->
58+
<dependency>
59+
<groupId>jakarta.servlet</groupId>
60+
<artifactId>jakarta.servlet-api</artifactId>
61+
<version>${servlet5.version}</version>
62+
</dependency>
5763
</dependencies>
5864

5965
<build>

containers/jetty-servlet/src/main/java/org/glassfish/jersey/jetty/servlet/JettyWebContainerFactory.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import java.net.URI;
2020
import java.util.Map;
2121

22-
import javax.servlet.Servlet;
22+
import jakarta.servlet.Servlet;
2323

2424
import org.glassfish.jersey.jetty.JettyHttpContainerFactory;
2525
import org.glassfish.jersey.servlet.ServletContainer;

containers/pom.xml

+2-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@
4141
<module>jersey-servlet-core</module>
4242
<module>jersey-servlet</module>
4343
<module>jetty-http</module>
44-
<module>jetty-servlet</module>
44+
<!-- TODO jakartify this -->
45+
<!-- <module>jetty-servlet</module>-->
4546
<module>netty-http</module>
4647
<module>simple-http</module>
4748
</modules>

0 commit comments

Comments
 (0)