Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[SERIOUS] Add Automatic-Module-Name in jakarta.servlet.jsp.jstl-x.x.x.jar manifest #58

Closed
PavelTurk opened this issue Jan 31, 2023 · 2 comments

Comments

@PavelTurk
Copy link

PavelTurk commented Jan 31, 2023

This is a piece from jakarta.servlet.jsp.jstl-api-2.0.0.jar manifest:

Manifest-Version: 1.0
Bundle-Description: Jakarta Standard Tag Library 2.0 Specification
Automatic-Module-Name: jakarta.servlet.jsp.jstl            <<< Note this line
Bundle-License: http://www.eclipse.org/legal/epl-2.0, https://www.gnu.
 org/software/classpath/license.html
Bundle-SymbolicName: jakarta.servlet.jsp.jstl-api
Implementation-Version: 2.0.0
Bundle-Name: Jakarta Standard Tag Library API

Now, lets consider implementation org.glassfish.web/jakarta.servlet.jsp.jstl/2.0.0 that has the following jar: jakarta.servlet.jsp.jstl-2.0.0.jar. This jar does NOT have Automatic-Module-Name in its manifest. As a result the following thing happens - these two jars modules cat NOT be used together. The reason is that they have similar module name.

The name of the API module comes from manifest (Automatic-Module-Name: jakarta.servlet.jsp.jstl) the name of the IMPL module comes from module name jakarta.servlet.jsp.jstl. So, ModuleFinder in JPMS can NOT work with two such modules and as result one module is always ignored. Besides, it is very difficult to understand why.

Same problem with jakarta.servlet.jsp.jstl-3.0.0

@PavelTurk PavelTurk changed the title [SERIOUS] Add Automatic-Module-Name in jakarta.servlet.jsp.jstl-2.0.0 manifest [SERIOUS] Add Automatic-Module-Name in jakarta.servlet.jsp.jstl-x.x.x.jar manifest Feb 1, 2023
@arjantijms
Copy link
Contributor

the name of the IMPL module comes from module name jakarta.servlet.jsp.jstl

In the next release of WaSP, the name will come from WaSP, and no longer from jakarta.servlet.jsp.jstl

@arjantijms
Copy link
Contributor

The WaSP module has been set to org.glassfish.wasp.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants