Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

config.h unconditionally defines _GNU_SOURCE #3141

Open
gdt opened this issue Oct 17, 2024 · 0 comments
Open

config.h unconditionally defines _GNU_SOURCE #3141

gdt opened this issue Oct 17, 2024 · 0 comments

Comments

@gdt
Copy link

gdt commented Oct 17, 2024

Visibility defines are generally problematic, and should be used only when necessary. It's not clear why this is present, and on what systems are needed. This ticket is about minimizing, perhaps reducing, this usage, and adding comments that justify it.

On a NetBSD system, removing it results in a clean build with no warnings. But that's likely not where it's intended.

(This could also lead to identifying and removing non-POSIX usage.)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant