Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

json: markers reported on start for files not opened #7154

Closed
vince-fugnitto opened this issue Feb 14, 2020 · 2 comments · Fixed by #10562
Closed

json: markers reported on start for files not opened #7154

vince-fugnitto opened this issue Feb 14, 2020 · 2 comments · Fixed by #10562
Labels
json issues related to the json language question user / developer questions

Comments

@vince-fugnitto
Copy link
Member

Description

When theia is used as a workspace, I noticed that json warnings are outputted (.theia), despite any of the files being opened. Is this the intended behavior? When verifying the same use case in VS Code, no warnings are present in the problems view:

image

Steps to Reproduce

  1. start the application (better to start with a fresh port and no local storage)
  2. open theia as a workspace (no files should be opened)
  3. the problems view outputs warnings for json files under .theia
@vince-fugnitto vince-fugnitto added question user / developer questions json issues related to the json language labels Feb 14, 2020
@akosyakov
Copy link
Member

@vince-fugnitto probably we store markers between sessions, do you think it is bad? misleading? or helpful since it shows you what is really wrong faster?

@vince-fugnitto
Copy link
Member Author

@vince-fugnitto probably we store markers between sessions, do you think it is bad? misleading? or helpful since it shows you what is really wrong faster?

I felt that, especially since they are warnings in this case, that displaying the markers on startup is a bit noisy. I noticed in VS Code this same behavior is not present, the markers are only visible when first opening the file and not on startup. I am surprised it'd store the markers between sessions, I made sure to start at a different port and also delete my local history. That is of course my own opinion, I wonder what others might think.

cc @marcdumais-work @lmcbout @marechal-p

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
json issues related to the json language question user / developer questions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants