From fc2c02a81a4e74e18317475da243ad3a3cb775b5 Mon Sep 17 00:00:00 2001 From: Jonah Iden Date: Fri, 29 Nov 2024 13:14:41 +0100 Subject: [PATCH 1/2] improve searchForDevontainerJsonFiles to not block server Signed-off-by: Jonah Iden --- .../src/electron-node/dev-container-file-service.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/dev-container/src/electron-node/dev-container-file-service.ts b/packages/dev-container/src/electron-node/dev-container-file-service.ts index 1eca1a0e48d28..3809e6c7793ce 100644 --- a/packages/dev-container/src/electron-node/dev-container-file-service.ts +++ b/packages/dev-container/src/electron-node/dev-container-file-service.ts @@ -49,7 +49,7 @@ export class DevContainerFileService { } protected async searchForDevontainerJsonFiles(directory: string, depth: number): Promise { - if (depth < 0 || !fs.existsSync(directory)) { + if (depth < 0 || ! await fs.pathExists(directory)) { return []; } const filesPaths = (await fs.readdir(directory)).map(file => new Path(directory).join(file).fsPath()); From 339935dec7b8764d1eea14b8f5831e53adb944d3 Mon Sep 17 00:00:00 2001 From: Jonah Iden Date: Fri, 29 Nov 2024 13:16:05 +0100 Subject: [PATCH 2/2] lint Signed-off-by: Jonah Iden --- .../src/electron-node/dev-container-file-service.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/dev-container/src/electron-node/dev-container-file-service.ts b/packages/dev-container/src/electron-node/dev-container-file-service.ts index 3809e6c7793ce..6987c0e73641a 100644 --- a/packages/dev-container/src/electron-node/dev-container-file-service.ts +++ b/packages/dev-container/src/electron-node/dev-container-file-service.ts @@ -49,7 +49,7 @@ export class DevContainerFileService { } protected async searchForDevontainerJsonFiles(directory: string, depth: number): Promise { - if (depth < 0 || ! await fs.pathExists(directory)) { + if (depth < 0 || !await fs.pathExists(directory)) { return []; } const filesPaths = (await fs.readdir(directory)).map(file => new Path(directory).join(file).fsPath());