-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: Use correct JSON-LD context prefix #257
fix: Use correct JSON-LD context prefix #257
Conversation
@leandro-cavalcante please refer to the policy standard of catena-x https://catenax-ev.github.io/docs/standards/CX-0018-DataspaceConnectivity i assume we would need to adjust the url regarding the cx-profile prefix
|
@leandro-cavalcante please also solve the conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the conflicts doing a rebase on upstream main. Your pull-request should not contain anything on the 'Files changed' page that is already present in the target-branch.
I will open a new PR with the necessary changes, I'm doing the rebase but the other commits are coming together and I do not have the option to drop them. |
e52c7e8
to
b54320b
Compare
@leandro-cavalcante I did remove the redundant commits leaving the conflict on your actual change. Please be aware that I did a force-push to do so. Of course you may also open a new PR reapplying your change to latest main if that is more easy for you. |
Thank you! |
@leandro-cavalcante to ensure a PR would not contain any unintended changes in the swagger-documentation one always needs run 'dotnet build' on the respective service module after rebase on main to regenerate the swagger (hub-service.yaml). Just did that for you but keep in mind for your next PR. |
|
Description
In the returned policies, the policy hub adds the https://w3id.org/catenax/v0.0.1/ns/ context with the cx prefix, but then uses the cx-policy prefix instead.
Why
The cx-policy prefix isn’t bound to any context within the JSON-LD document and therefore will fail to expand during serialization.
Issue
N/A
Issue
Link to Github issue.
Checklist
Please delete options that are not relevant.