Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Using FileSystem closes all the ressources when using an URLClassLoader #5043

Closed
adrien-aubert-drovio opened this issue Dec 20, 2023 · 1 comment · Fixed by #5044
Closed
Assignees
Labels
Milestone

Comments

@adrien-aubert-drovio
Copy link

Version

4.5.1

Context

When deploying a verticle using an URLClassLoader (when loading classes from a JAR file), using the vertx.fileSystem() to read files/directories will close the opened resources related to the JAR file once the operation completes. For example, if an InputStream is opened to read a file from the JAR file, the InputStream will be closed as well, even if it is still in use.

There is no problem with version 4.4.6 of Vertx.

Do you have a reproducer?

https://github.com/adrien-aubert-drovio/vertx-url-class-loader-read-file/tree/main

Extra

Tested on MacOs with Java 11 and 17.

@vietj vietj added this to the 4.5.2 milestone Dec 20, 2023
@vietj vietj self-assigned this Dec 20, 2023
@vietj
Copy link
Member

vietj commented Dec 20, 2023

thanks for reporting, this is a regression

@vietj vietj closed this as completed Dec 21, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants