Make methods getAttribute(s)/setAttribute(s) of AdjustedLaunchConfigurationWorkingCopy symmetric #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchof
reviewed
Nov 7, 2021
.../src/org/eclipse/eclemma/internal/core/launching/AdjustedLaunchConfigurationWorkingCopy.java
Outdated
Show resolved
Hide resolved
The current implementation produces duplicate vmArguments in the following scenario: 1. We call getAttribute() or getAttributes() on an object of type AdjustedLaunchConfigurationWorkingCopy, which concatenates the extraVMArguments with the VM arguments from the delegate 2. Now we pass the vmArguments to the setAttribute() method, which will modify the underlying WorkingCopy info object -> delegate.setAttribute() 3. When we now call the getAttribute() method again, it will once again concatenate the extraVMArguments with the modified VM arguments from the delegate.getAttribute() method. The solution here is to make the following methods symmetric: * getAttribute/setAttribute for String arguments * getAttributes/setAttributes The setAttribute(s) methods will filter the extraVMArguments before passing the value to the delegate.setAttribute(s) method.
LukasPecak
force-pushed
the
bugfix/make_setAttribute_and_getAttribute_methods_symmetric
branch
from
66e4660 to
ec352d3
Compare
marchof
approved these changes
Nov 10, 2021
|
@Godin Can you have also have a look please? |
Godin
force-pushed
the
bugfix/make_setAttribute_and_getAttribute_methods_symmetric
branch
from
a79a87e to
534c685
Compare
Godin
changed the title
Godin
approved these changes
Nov 22, 2021
There was a problem hiding this comment.
Please excuse me for slow processing of this PR.
Quality of this contribution is outstanding! 👍
Thanks a lot @LukasPecak ❤️
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation produces duplicate vmArguments in the following scenario:
The solution here is to make the following methods symmetric:
The setAttribute(s) methods will filter the extraVMArguments before passing the value to the delegate.setAttribute(s) method.