Port from moment to dayjs (#218)

* Move much of lib/notifications to server/notifications
* Convert to exports
* Reduce bundle size by ~46kB

Author: edemaine

.eslintrc.yml

@@ -29,7 +29,6 @@ globals:
   Template: readonly
   Tracker: readonly
   WebApp: readonly
-  moment: readonly
   # Coauthor databases
   Emoji: readonly
   EmojiMessages: readonly
@@ -117,11 +116,9 @@ globals:
   message2root: readonly
   messageReaders: readonly
   messageRoleCheck: readonly
-  messageSubscribers: readonly
   messagesBy: readonly
   messagesByQuery: readonly
   messagesTaggedQuery: readonly
-  momentInUserTimezone: readonly
   notifyMessageUpdate: readonly
   pathFor: readonly
   pluralize: readonly
@@ -135,7 +132,6 @@ globals:
   setTitle: readonly
   sortedGroupFullMembers: readonly
   sortedGroupPartialMembers: readonly
-  subscribedToMessage: readonly
   titleOrUntitled: readonly
   titleSort: readonly
   undeletedMessagesQuery: readonly

client/group.coffee

@@ -23,6 +23,7 @@ import {UserLink} from './UserLink'
 import {emojiReplies} from '/lib/emoji'
 import {formatTitleOrFilename} from '/lib/formats'
 import {groupDefaultSort, parseSort, unparseSort} from '/lib/groups'
+import {subscribedToMessage} from '/lib/notifications'
 import {autopublish} from '/lib/settings'
 import {groupTags, sortTags} from '/lib/tags'
 

client/lib/moment.coffee

@@ -29,7 +29,7 @@ import {prefersReducedMotion, scrollBehavior} from './lib/scroll'
 import {allEmoji} from '/lib/emoji'
 import {availableFormats, formatBody, formatFile, formatFileDescription, formatTitleOrFilename, parseCoauthorAuthorUrl, parseCoauthorMessageUrl} from '/lib/formats'
 import {ancestorMessages, descendantMessagesQuery, messageDiffsExpanded, messageNeighbors, sortedMessageReaders} from '/lib/messages'
-import {autosubscribe, defaultNotificationsOn} from '/lib/notifications'
+import {autosubscribe, defaultNotificationsOn, messageSubscribers} from '/lib/notifications'
 import {autopublish, defaultKeyboard, userKeyboard, themeEditor} from '/lib/settings'
 import {escapeTag, sortTags} from '/lib/tags'
 

client/message.coffee

@@ -2,6 +2,7 @@ import React, {useEffect, useMemo, useRef} from 'react'
 import Dropdown from 'react-bootstrap/Dropdown'
 import {useTracker} from 'meteor/react-meteor-data'
 import Blaze from 'meteor/gadicc:blaze-react-component'
+import dayjs from 'dayjs'
 
 import {ErrorBoundary} from './ErrorBoundary'
 import {TextTooltip} from './lib/tooltip'
@@ -305,43 +306,45 @@ buildStats = (stats, unit, weekStart) ->
       coauthors: true
     sort: created: 1
   stats.msgCount = msgs.count()
-  console.log stats.msgCount
   switch unit
     when 'hour'
-      msgs = _.sortBy msgs.fetch(), (msg) -> moment(msg.created).format 'HH:mm'
+      msgs = _.sortBy msgs.fetch(), (msg) -> dayjs(msg.created).format 'HH:mm'
     when 'weekday'
-      msgs = _.sortBy msgs.fetch(), (msg) -> moment(msg.created).day()
+      msgs = _.sortBy msgs.fetch(), (msg) -> dayjs(msg.created).day()
   msgs.forEach (msg) ->
     increment = unit
     switch unit
       when 'week'
-        day = moment(msg.created).startOf 'day'
+        day = dayjs(msg.created).startOf 'day'
         if day.day() < weekStart
-          day.day -7 + weekStart  ## previous week
+          day = day.day -7 + weekStart  ## previous week
         else
-          day.day weekStart  ## same week
+          day = day.day weekStart  ## same week
       when 'hour'
-        day = moment(msg.created).startOf unit
+        day = dayjs msg.created
+        .startOf unit
         .year 2000
-        .dayOfYear 1
+        .month 0
+        .date 1
       when 'weekday'
-        day = moment(msg.created).startOf 'day'
-        day = day.date 1 + moment(msg.created).day()
+        day = dayjs msg.created
+        .startOf 'day'
+        .date 1 + dayjs(msg.created).day()
         .month 9
         .year 2000  ## 1st day of October 2000 is a Sunday
         increment = 'day'
       else
-        day = moment(msg.created).startOf unit
+        day = dayjs(msg.created).startOf unit
     if lastDate?
-      if lastDate.valueOf() > day.valueOf()
+      if lastDate.isAfter day
         console.warn "Backwards time travel from #{lastDate.format()} to #{day.format()}"
         lastDate = day
         makeDay()
       else
-        while lastDate.valueOf() != day.valueOf()
+        until lastDate.isSame day
           lastDate = lastDate.add 1, increment
           makeDay()
-          if lastDate.valueOf() > day.valueOf()
+          if lastDate.isAfter day
             console.warn "Bad day handling (Coauthor bug)"
             break
     else

client/stats.coffee

@@ -2,6 +2,7 @@ import {check, Match} from 'meteor/check'
 import {Mongo} from 'meteor/mongo'
 
 import {escapeKey, unescapeKey, validKey} from './escape'
+import {subscribedToMessage} from './notifications'
 import {profilingStartup} from './profiling'
 
 @wildGroup = '*'

lib/groups.coffee

@@ -1,6 +1,7 @@
 import {check, Match} from 'meteor/check'
 import {Mongo} from 'meteor/mongo'
 import {ShareJS} from 'meteor/edemaine:sharejs'
+import dayjs from 'dayjs'
 
 import {dateMax} from './dates'
 import {groupDefaultSort} from './groups'
@@ -425,16 +426,16 @@ export parseSince = (since) ->
     if match?
       amount = parseFloat match[1]
       return null if isNaN amount
-      moment().subtract(amount, match[2]).toDate()
+      dayjs().subtract(amount, match[2]).toDate()
     else
       match = /^\s*(\d+)\s*:\s*(\d+)\s*$/.exec since
       if match?
-        d = moment().hour(match[1]).minute(match[2])
-        if moment().diff(d) < 0
+        d = dayjs().hour(match[1]).minute(match[2])
+        if dayjs().isBefore d
           d = d.subtract(1, 'day')
         d.toDate()
       else
-        d = moment(since)
+        d = dayjs(since)
         return null unless d.isValid()
         d.toDate()
   catch