Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: netscan search only for NetworkVideoTransmitter #136

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

ajcasagrande
Copy link
Contributor

@ajcasagrande ajcasagrande commented Aug 16, 2022

Signed-off-by: Anthony Casagrande anthony.j.casagrande@intel.com

Related: #134
Related: #135

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
    • no existing unit tests
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Upgraded IOTechSystems/onvif from v0.1.3 to v0.1.4

Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
@codecov-commenter
Copy link

Codecov Report

Merging #136 (3421989) into main (7dcacfa) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #136      +/-   ##
========================================
- Coverage   9.13%   9.12%   -0.02%     
========================================
  Files         18      18              
  Lines       1795    1797       +2     
========================================
  Hits         164     164              
- Misses      1610    1612       +2     
  Partials      21      21              
Impacted Files Coverage Δ
internal/driver/driver.go 1.12% <0.00%> (-0.01%) ⬇️
internal/driver/macmapper.go 38.66% <ø> (ø)
internal/driver/onvifdiscovery.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lenny-goodell
Copy link
Member

@ajcasagrande , please fill out the PR checklist for all PRs. THX!

@ajcasagrande
Copy link
Contributor Author

@lenny-intel PR checklist filled out

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajcasagrande ajcasagrande merged commit a7f4bbd into edgexfoundry:main Aug 16, 2022
@ajcasagrande ajcasagrande deleted the netscan-fix branch August 16, 2022 22:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants