Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: remove custom service interface and use sdk interface #150

Conversation

ajcasagrande
Copy link
Contributor

Signed-off-by: Anthony Casagrande anthony.j.casagrande@intel.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • N/A I have opened a PR for the related docs change (if not, why?)

Testing Instructions

Closes #128

New Dependency Instructions (If applicable)

Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Copy link
Contributor

@brianointel brianointel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajcasagrande ajcasagrande merged commit 87f15e2 into edgexfoundry:main Sep 1, 2022
@ajcasagrande ajcasagrande deleted the remove-service-interface branch September 1, 2022 16:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove service wrapper and service mock
3 participants