Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: discovery mode netscan when using docker-compose #176

Merged
merged 2 commits into from
Oct 12, 2022

Conversation

edgego
Copy link
Contributor

@edgego edgego commented Oct 12, 2022

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Signed-off-by: edgego <tianxingguo@gmail.com>
Signed-off-by: edgego <tianxingguo@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #176 (0e550ce) into main (bca8455) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
- Coverage   30.86%   30.82%   -0.04%     
==========================================
  Files          18       18              
  Lines        1808     1810       +2     
==========================================
  Hits          558      558              
- Misses       1185     1187       +2     
  Partials       65       65              
Impacted Files Coverage Δ
internal/driver/driver.go 12.64% <0.00%> (-0.06%) ⬇️
internal/driver/onvifdiscovery.go 26.88% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@ajcasagrande ajcasagrande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edgego Everything looks in order, and I will merge.Thank you for your contribution!

@ajcasagrande ajcasagrande merged commit 6644798 into edgexfoundry:main Oct 12, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants