-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
docs: integrate onvif schemas and validation matrix to swagger #180
docs: integrate onvif schemas and validation matrix to swagger #180
Conversation
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Codecov Report
@@ Coverage Diff @@
## main #180 +/- ##
=======================================
Coverage 30.82% 30.82%
=======================================
Files 18 18
Lines 1810 1810
=======================================
Hits 558 558
Misses 1187 1187
Partials 65 65 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still looking through this, but I think that are too many output statements. Maybe an option to disable it or just removing some of the more extraneous ones would be mote helpful.
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
@ChristianDarr-personal I agree. The prints were helpful when creating the scripts, but now they are just noise. I have switched to using the python |
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Lots of additional changes/improvements to the swagger generation:
core-command
serviceGET
calls withjsonObject
field, provide documentation on the format and schema of the field, along with descriptions of each field.ruamel.yaml
to allow multi-line strings to support Markdown sytanx for description fields.PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
Browse the hosted version:
https://app.swaggerhub.com/apis-docs/ANTHONYJINTEL/edge-x_onvif_device_service/2.2.0
New Dependency Instructions (If applicable)
JavaScript:
Python:
A few example screenshots:
jsonObject schema:
![](https://user-images.githubusercontent.com/48735240/196547540-f1a5a8fa-92f3-49d2-846c-4004c2ab724a.png)
tested cameras matrix:
![](https://user-images.githubusercontent.com/48735240/196547682-d63ce0a4-3c42-415b-92ab-88aa97edad3b.png)
response event/object schemas:
![](https://user-images.githubusercontent.com/48735240/196547720-4d9c043f-872b-44e7-bc2f-a56eb0286d82.png)