Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add GetCapabilities and GetEndpointReference #189

Merged

Conversation

ajcasagrande
Copy link
Contributor

  • Adds general GetCapabilities
  • Adds GetServiceCapabilities for each service
  • Adds GetEndpointReference command

Signed-off-by: Anthony Casagrande anthony.j.casagrande@intel.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

See updated postman collection for how to call the commands.

MAKE SURE YOU ARE USING THE LATEST DEVICE PROFILES PROVIDED HERE
The easiest way of ensuring this is to run a make clean and start fresh on the edgex-compose project.

New Dependency Instructions (If applicable)

- Adds general GetCapabilities
- Adds GetServiceCapabilities for each service
- Adds GetEndpointReference command

Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Copy link
Contributor

@brianointel brianointel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ajcasagrande ajcasagrande merged commit 8e26798 into edgexfoundry:main Oct 27, 2022
@ajcasagrande ajcasagrande deleted the add-capabilities branch October 27, 2022 22:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants