Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor(snap): Refactor and upgrade to edgex-snap-hooks v3 #217

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

farshidtz
Copy link
Member

Upgrade to edgex-snap-hooks v3:

  • Remove enabling of app options since it is enabled by default in the library
  • Upgrade edgex-snap-testing Github action to v3
  • Add snap's Go module to dependabot
  • Other minor refactoring

Signed-off-by: Farshid Tavakolizadeh farshid.tavakolizadeh@canonical.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-virtual-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
- Remove enabling of app options since it is enabled by default in the library
- Other code refactoring

Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
@farshidtz farshidtz marked this pull request as ready for review January 16, 2023 17:45
@farshidtz farshidtz requested a review from MonicaisHer January 16, 2023 17:45
Copy link
Contributor

@MonicaisHer MonicaisHer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farshidtz Thank you, looks good!

@farshidtz farshidtz merged commit 6741b26 into edgexfoundry:main Jan 17, 2023
@farshidtz farshidtz deleted the v3-snap-upgrade branch January 17, 2023 17:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants