Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor(snap): Update command and metadata sourcing #270

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

MonicaisHer
Copy link
Contributor

@MonicaisHer MonicaisHer commented Mar 16, 2023

  • Inline CLIs flags
  • Remove unused packages
  • Remove external metadata sourcing

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

Build snap from this PR:

snap install --channel stable --classic snapcraft
snapcraft --use-lxd
# Snapped edgex-device-onvif-camera_3.0.0-dev.20_amd64.snap

Start the device:

sudo snap install --dangerous ./edgex-device-onvif-camera_3.0.0-dev.20_amd64.snap
sudo snap install edgexfoundry --channel=latest/edge
sudo snap connect edgexfoundry:edgex-secretstore-token edgex-device-onvif-camera:edgex-secretstore-token
sudo snap start --enable edgex-device-onvif-camera.device-onvif-camera

Check metadata:

$ snap info edgex-device-onvif-camera
name:      edgex-device-onvif-camera
summary:   EdgeX ONVIF Camera Device Service
publisher: –
store-url: https://snapcraft.io/edgex-device-onvif-camera
license:   Apache-2.0
description: |
  Refer to https://snapcraft.io/edgex-device-onvif-camera
services:
  edgex-device-onvif-camera.device-onvif-camera: simple, enabled, active
refresh-date: today at 11:10 CET
channels:
  latest/stable:    2.3.0        2022-11-11 (234) 12MB -
  latest/candidate: ↑                                  
  latest/beta:      ↑                                  
  latest/edge:      3.0.0-dev.21 2023-03-17 (465) 12MB -
installed:          3.0.0-dev.20             (x2) 12MB -

New Dependency Instructions (If applicable)

- Inline CLIs flags
- Remove unused packages
- Remove external metadata sourcing

Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
@presatish
Copy link
Contributor

@MonicaisHer Can you please add the testing instructions above?

@MonicaisHer
Copy link
Contributor Author

@presatish I have included the test instructions above. Here is also a GitHub Action for automatically testing Snap-related functions.

@MonicaisHer MonicaisHer requested a review from farshidtz March 17, 2023 08:31
@farshidtz farshidtz merged commit 77ccddf into edgexfoundry:main Mar 17, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants