-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
docs: remove demo-app docs #273
docs: remove demo-app docs #273
Conversation
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #273 +/- ##
=======================================
Coverage 33.53% 33.53%
=======================================
Files 18 18
Lines 1792 1792
=======================================
Hits 601 601
Misses 1125 1125
Partials 66 66 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README.md file referred in some places and the links to it are broken for some reason. For e.g. https://github.com/EdgeX-Camera-Management/device-onvif-camera/blob/remove-demo-app-docs/doc/general-usage.md#next-steps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need some minor changes.
@@ -31,8 +31,6 @@ The figure below illustrates the software flow through the architecture componen | |||
|
|||
# Getting Started | |||
|
|||
Learn how to configure and run the service by following these [instructions](./doc/setup.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as other people, what do we want to do with the files left dangling from removing this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for now we can leave these files as it is at least until we migrate everything to edgex docs.
Signed-off-by: preethi-satishcandra <preethi.satishchandra@intel.com>
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
New Dependency Instructions (If applicable)