Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: remove demo-app docs #273

Merged

Conversation

ajcasagrande
Copy link
Contributor

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • [N/A] I have added unit tests for the new feature or bug fix (if not, why?)
  • [N/A] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • [N/A] I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2023

Codecov Report

Merging #273 (ee4e5af) into main (35e0b63) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage   33.53%   33.53%           
=======================================
  Files          18       18           
  Lines        1792     1792           
=======================================
  Hits          601      601           
  Misses       1125     1125           
  Partials       66       66           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@presatish presatish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md file referred in some places and the links to it are broken for some reason. For e.g. https://github.com/EdgeX-Camera-Management/device-onvif-camera/blob/remove-demo-app-docs/doc/general-usage.md#next-steps

Copy link
Contributor

@presatish presatish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some minor changes.

@@ -31,8 +31,6 @@ The figure below illustrates the software flow through the architecture componen

# Getting Started

Learn how to configure and run the service by following these [instructions](./doc/setup.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as other people, what do we want to do with the files left dangling from removing this line?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for now we can leave these files as it is at least until we migrate everything to edgex docs.

Signed-off-by: preethi-satishcandra <preethi.satishchandra@intel.com>
@presatish presatish merged commit 30f142b into edgexfoundry:main Mar 20, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants