feat: implement secret change support, refactor cred mgmt #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #333 +/- ##
==========================================
+ Coverage 33.38% 33.95% +0.56%
==========================================
Files 18 18
Lines 1800 1832 +32
==========================================
+ Hits 601 622 +21
- Misses 1133 1143 +10
- Partials 66 67 +1
|
presatish
requested changes
May 3, 2023
ajcasagrande
commented
May 3, 2023
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
lenny-goodell
requested changes
May 3, 2023
secret cache was being used in a redundant manner, as secret store already caches some data. Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
New Dependency Instructions (If applicable)