Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow search mudule to take options #100

Merged
merged 1 commit into from
Feb 18, 2017

Conversation

shotat
Copy link
Contributor

@shotat shotat commented Nov 5, 2016

#70
Unexpected rate limit error occurs because of pagination and streaming in search.ex.
Now we can control pagination options in each functions.

    params = %{ q: repository_name, per_page: 1 }
    options = [ pagination: :none ]
    # This code does not work because of auto streaming pagination processes with rate limits.
    # response = Tentacat.Search.repositories(params, client)

    # This code works (workaround...).
    # response = Tentacat.get "search/repositories", client, params, options

    # Now this code works (on this PR).
    response = Tentacat.Search.repositories(params, client, options)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.625% when pulling 5226457 on shotat:feature/search-optional into 191f1f8 on edgurgel:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.625% when pulling 5226457 on shotat:feature/search-optional into 191f1f8 on edgurgel:master.

@shotat shotat force-pushed the feature/search-optional branch from 5226457 to dc84c9d Compare December 1, 2016 14:20
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.667% when pulling dc84c9d on shotat:feature/search-optional into 0c95034 on edgurgel:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.667% when pulling dc84c9d on shotat:feature/search-optional into 0c95034 on edgurgel:master.

@shotat
Copy link
Contributor Author

shotat commented Dec 1, 2016

Why does this branch fail?

@sergey-kintsel
Copy link
Contributor

@shotat each PR fails due to some strange bug. Maybe there are some differences between Elixir 1.0 and Elixir 1.1 which caused this issue. Anyway, I think that we need to remove Elixir 1.0 from Travis matrix because HTTPoison requires 1.2

@bigardone
Copy link
Contributor

Hi! Any plans for merging this PR?
Cheers!

@shotat
Copy link
Contributor Author

shotat commented Feb 18, 2017

Now Elixir 1.0 was removed from Travis matrix, so this PR might pass all checks.

I close this PR and reopen to trigger builds again.

http://stackoverflow.com/questions/17606874/trigger-a-travis-ci-rebuild-without-pushing-a-commit

@shotat shotat closed this Feb 18, 2017
@shotat shotat reopened this Feb 18, 2017
@coveralls
Copy link

coveralls commented Feb 18, 2017

Coverage Status

Coverage increased (+0.3%) to 90.987% when pulling dc84c9d on shotat:feature/search-optional into 0c95034 on edgurgel:master.

@edgurgel edgurgel merged commit 72832a6 into edgurgel:master Feb 18, 2017
@edgurgel
Copy link
Owner

Thanks! 🎉

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants