Adds the search code API #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sort and order parameters are optional, so there is one function that takes those arguments and one that doesn't.
In order to able to use GitHub's querying language on the URL, it must be possible not to URL encode it.
| @@ -56,9 +56,9 @@ defmodule Tentacat do | |||
| _request(:put, url(client, path), client.auth, body) | |||
| end | |||
|
|
|||
| def get(path, client, params \\ []) do | |||
| def get(path, client, params \\ [], encode \\ true) do | |||
There was a problem hiding this comment.
Can we make this an option as a keyword list?
Something like
def get(path, client, params \\ [], options \\ [])
Keyword.get(options, :encode, true)
It would be clearer than just passing true/false
|
I'm sorry for the massive delay! |
|
Apparently GitHub API has changed, so I updated the examples, and now I don't remember why I needed the non encoded url, so I just removed that code. I can put it back in if you want. |
|
works on my machine :) and looks good to me - thanks! @zamith |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sort and order parameters are optional, so there is one function
that takes those arguments and one that doesn't.