Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

read and use additional :request_options on request!/5 #69

Merged
merged 2 commits into from
Mar 28, 2016

Conversation

killerswan
Copy link
Contributor

This allows overriding the default options in configuration, like so:

config :tentacat, request_options: [
    {:ssl, [
        {:cacertfile, "/etc/mysvc/mycert.pem"}
    ]}
]

One possible solution to issue #66. 😇

This allows overriding the default options in configuration, like so:

```elixir
config :tentacat, request_options: [
    {:ssl, [
        {:cacertfile, "/etc/mysvc/mycert.pem"}
    ]}
]
```
@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 84.277% when pulling 65e8c9f on killerswan:req-opts into 7f0914f on edgurgel:master.

@edgurgel
Copy link
Owner

LGTM. What do you think, @duksis ?

@duksis
Copy link
Collaborator

duksis commented Mar 28, 2016

Some suggestions from my side:

  1. Add the example snippet from this PR description to documentation - maybe readme
  2. Rename extra_options to config_options and extract them to a private function
defp config_options
  Application.get_env(:tentacat, :request_options, [])
end

valuable addition even without implementing my suggestions.
thanks @killerswan 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants