Add pagination and streaming #70
Conversation
|
Hmm.. I'm using URI.to_string, which is only available in Elixir 1.1+. @edgurgel, @duksis, thoughts on bumping minimum Elixir version to 1.1? |
|
Also just saw #69 merged, I should update to use those options as well. Standby... |
jeffweiss
force-pushed
the
add_pagination
branch
from
c57578d to
8de890f
Compare
|
first of all - thanks for the amazing contribution @jeffweiss ! In regards of bumping required Elixir version, I would prefer backporting URI.to_string for Elixir 1.0 than dropping the support for it. |
|
I agree, @duksis. Let's do this in 2 stages. |
|
Oh, we might not need to backport anything. It looks like |
Prior to this commit Tentacat was using `URI.to_string` for converstion
of the URI struct to a binary. While this works in Elixir 1.1+, Elixir
1.0 does not have a `URI.to_string`. This commit changes the function
call to `String.Chars.to_string(%URI{})` which *does* exist in Elixir
1.0 (and later).
NOTE: I expect this commit to be reverted for readability once Elixir
1.0 support is dropped.
|
\o/ --- If you have other changes you'd like me to make lemme know. |
|
thanks! We will let you know when other changes will be needed. 😉 |
|
👍 We should release a new version with this contribution. I should give owner access to you @duksis. Do you have an e-mail registered with hex so I can add you? :) |
|
@edgurgel should be duksis@gmail.com |
🎉 |
Close #67