Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add <credits tags #39

Closed
th0ma7 opened this issue Jun 1, 2021 · 1 comment
Closed

Add <credits tags #39

th0ma7 opened this issue Jun 1, 2021 · 1 comment

Comments

@th0ma7
Copy link

th0ma7 commented Jun 1, 2021

Credits are currently managed through the <desc tag such as:

                <desc lang="en">PREMIERE
Une petite Japonaise doit se plier avec docilité à l&apos;initiation difficile qui fera d&apos;elle une geisha, triomphant des pièges tortueux que lui tend sa rivale.
G | Released: 2005 | Cast: Zhang Ziyi, Ken Watanabe, Michelle Yeoh, Kôji Yakusho, Youki Kudoh, Gong Li, Kaori Momoi, Tsai Chin, Cary-Hiroyuki Tagawa, Suzuka Ohgo, Randall Kim, Mako , Kenneth Tsang, Thomas Ikeda, Zoe Weizenbaum, Shizuko Hoshi, Paul Adelstein, Anthony Begonia, Togo Tanaka, Eugenia Yuan, Chad Cleven, Michael Kuroiwa, Yôko Narahashi </desc>

Instead it can be managed such as:

    <credits>
      <director>Greg Colton</director>
      <director>Dominic Bianchi</director>
      <writer>Seth MacFarlane</writer>
      <actor role="Peter Griffin">Seth MacFarlane</actor>
      <actor role="Lois Griffin">Alex Borstein</actor>
    </credits>

In fact, in the JSON entry:

{"priority":"1","type":"Cast","role":"Actor","characterName":"Sayuri Nitta","assetId":"226862_v9_bb","name":"Zhang Ziyi"}

There is even the character name is available and seems to be able to be used such as:

<credits>
  <actor role="Jerry Seinfeld">Jerry Seinfeld</actor>
  <actor role="Elaine Benes">Julia Louis-Dreyfus</actor>
  <actor role="George Costanza">Jason Alexander</actor>
  <actor role="Cosmo Kramer">Michael Richards</actor>
  <producer>Larry David</producer>
  <producer>George Shapiro</producer>
  <producer>Howard West</producer>
</credits>

As well as an icon from the "assetId":"86821_v9_ba" which refers to URL: https://zap2it.tmsimg.com/assets/226862_v9_bb.jpg
But nowhere I could find how to add the <icon src= tag related to an actor.
Unless it is <actor role="..." src="...">blabla</actor

@th0ma7
Copy link
Author

th0ma7 commented Jun 3, 2021

Fixed with 3daa50f and 6b9fdcc part of PR #37

@th0ma7 th0ma7 closed this as completed Jun 3, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant