Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Document Shader.bytecodeShader API change in version 1.10.0 #56

Open
lefou opened this issue Mar 14, 2024 · 2 comments
Open

Document Shader.bytecodeShader API change in version 1.10.0 #56

lefou opened this issue Mar 14, 2024 · 2 comments

Comments

@lefou
Copy link

lefou commented Mar 14, 2024

PR #37 introduced a source/binary incompatibility due to the removal of:

Shader.bytecodeShader(rules: Seq[ShadeRule], verbose: Boolean)

There is now a new method:

Shader.bytecodeShader(rules: Seq[ShadeRule], verbose: Boolean, skipManifest: Boolean)

What it the correct migration from the old to the new one?

Originally posted by @lefou in #37 (comment)

@lefou lefou changed the title This PR introduced a source/binary incompatibility due to the removal of: Document Shader.bytecodeShader API change Mar 14, 2024
@lefou lefou changed the title Document Shader.bytecodeShader API change Document Shader.bytecodeShader API change in version 0.1.10 Mar 14, 2024
@lefou lefou changed the title Document Shader.bytecodeShader API change in version 0.1.10 Document Shader.bytecodeShader API change in version 1.10.0 Mar 14, 2024
@SethTisue
Copy link
Contributor

Would it be appropriate to enable MiMa in this repo...?

@eed3si9n
Copy link
Owner

Whether you you skip manifest probably is case by case? Depending on what you are shading I guess it's potentially a source of conflict. Passing skipManifest = true should retain the old behavior.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants