Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

"its property must be something" doesn't work with boolean value #232

Closed
melcloud opened this issue Mar 6, 2020 · 3 comments
Closed

"its property must be something" doesn't work with boolean value #232

melcloud opened this issue Mar 6, 2020 · 3 comments
Assignees
Labels
bug waiting for confirmation Workaround/Fix applied, waiting for confirmation

Comments

@melcloud
Copy link

melcloud commented Mar 6, 2020

Description :
It seems that the new syntax doesn't work with boolean value
To Reproduce

  1. main.tf
resource "aws_lb" "internal" {
  name               = "${local.project_name_dash}-alb"
  internal           = true
  load_balancer_type = "application"

  security_groups = [
    module.alb_sg.this_security_group_id,
    data.terraform_remote_state.shared.outputs.internal_https_only_sg
  ]

  subnets                          = data.terraform_remote_state.shared.outputs.private_subnets[*].id
  enable_cross_zone_load_balancing = true
  idle_timeout                     = var.alb_idle_timeout
  enable_deletion_protection       = var.environment == "prod" ? true : false

  tags = merge(local.tags, { Name = "${local.project_name_dash}-alb" })
}
  1. -f test -p tfplan
  2. docker
  3. error:
    Scenario: Application load balancer must be internal
        Given I have aws_lb defined
                        Failure: Can not find true in internal property of aws_lb.internal.
        Then its internal must be true
          Failure: 
  1. <Your feature/scenario/steps>
    Scenario: Application load balancer must be internal
        Given I have aws_lb defined
        Then its internal must be true

Expected behavior :

Tested versions :

  • 1.1.11
  • terraform 0.12.21

Additional context
The old way works:

    Scenario: Application load balancer must be internal
        Given I have aws_lb defined
        Then it must contain internal
        And its value must be true
@melcloud melcloud added the bug label Mar 6, 2020
eerkunt added a commit that referenced this issue Mar 6, 2020
@eerkunt
Copy link
Member

eerkunt commented Mar 6, 2020

Very similar problem to #231. This is also fixed in the master branch.

Will release both very soon.

@eerkunt eerkunt added the ready for release Fix/Enhancement is implemented, will be released in next release cycle. label Mar 6, 2020
@eerkunt
Copy link
Member

eerkunt commented Mar 30, 2020

Can you have a try with 1.1.13 please ?

@eerkunt eerkunt added waiting for confirmation Workaround/Fix applied, waiting for confirmation and removed ready for release Fix/Enhancement is implemented, will be released in next release cycle. labels Mar 30, 2020
@melcloud melcloud closed this as completed Apr 2, 2020
@ghost
Copy link

ghost commented Apr 2, 2020

This issue's conversation is now locked. If you want to continue this discussion please open a new issue.

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
bug waiting for confirmation Workaround/Fix applied, waiting for confirmation
Projects
None yet
Development

No branches or pull requests

2 participants