Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add noskip tag #301

Merged
merged 6 commits into from
Jun 19, 2020
Merged

Add noskip tag #301

merged 6 commits into from
Jun 19, 2020

Conversation

Kudbettin
Copy link
Member

@Kudbettin Kudbettin commented Jun 17, 2020

Added noskip tag.

Possible invocations:

@noskip
Scenario: scenario

Fails if there's a skip in the scenario

@noskip_at_lines_12_23_25
Scenario: scenario

Fails if there's a skip on lines 12, 23, or 25.

The tag can not be used with @nofail at the same time.

Addresses issues #291, #292

@coveralls
Copy link

coveralls commented Jun 17, 2020

Pull Request Test Coverage Report for Build 1068

  • 13 of 34 (38.24%) changed or added relevant lines in 3 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 59.497%

Changes Missing Coverage Covered Lines Changed/Added Lines %
terraform_compliance/extensions/ext_radish_bdd.py 4 8 50.0%
terraform_compliance/common/bdd_tags.py 8 25 32.0%
Files with Coverage Reduction New Missed Lines %
terraform_compliance/common/defaults.py 6 83.78%
Totals Coverage Status
Change from base Build 1067: -0.06%
Covered Lines: 1206
Relevant Lines: 2027

💛 - Coveralls

Copy link
Member

@eerkunt eerkunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, great additional functionality. 🎉

@eerkunt eerkunt merged commit d5b0c34 into terraform-compliance:master Jun 19, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants