Fix "resource that supports" to accommodate "after_unknown" values #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerkunt
requested changes
Jan 7, 2021
| Note: This function may be extended to capture 'after' values as well. That would require flattening the multi level | ||
| dictionaries in resource | ||
| ''' | ||
| def remember_after_unknown(self, resource, after_unknown): |
|
|
||
| # if resource doesn't have type field, try to extract it from address | ||
| if not resource_type and 'address' in resource and resource['address']: | ||
| resource_type = resource.get('address').split('.')[0] |
There was a problem hiding this comment.
True, then we would most likely need to use resource.get('address').split('.')[2] in that case.
However, I'm inclined to delete this clause all together. Is it possible to not have type in resource at first place?
There was a problem hiding this comment.
Not sure, I think that depends on the provider really.
There was a problem hiding this comment.
I made the change. However, we might run into a similar issue with the resource's address convention if provider doesn't add the type of the resource to the plan.
ghost
mentioned this pull request
|
Might want to add the feature file to the test dir? :) |
|
Haha yes, I agree with @sleightsec here :) |
Kudbettin
force-pushed
the
fix_issue-438
branch
from
5763a46 to
7d7e8d6
Compare
eerkunt
previously approved these changes
Jan 10, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where the omission of
after_unknownvalues were breaking the Given stepresource that supports.Addresses #438, #441
Please note, in this setup the regular Given works well:
using
Given I have aws_rds_cluster definedwith the other two steps:Also note that kms_key_id is going to be an after_unknown value if and only if kms_key_id has a bad value (e.g. null)
So the
Given I have resource that supports kms_key_id definedstep is the culprit of this bug, as opposed to the omission ofafter_unknownvalues