Skip to content

fix: path completion #5

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jun 26, 2021
Merged

fix: path completion #5

merged 2 commits into from
Jun 26, 2021

Conversation

liu-lihao
Copy link
Contributor

No description provided.

@liu-lihao liu-lihao closed this May 2, 2021
@liu-lihao liu-lihao reopened this May 2, 2021
@liu-lihao liu-lihao closed this May 2, 2021
@liu-lihao liu-lihao reopened this May 2, 2021
@liu-lihao
Copy link
Contributor Author

#4

@walpolea
Copy link

walpolea commented May 27, 2021

Will this pr get merged? Could really use this path fix! @egoist

@liu-lihao
Copy link
Contributor Author

Will this pr get merged? Could really use this path fix! @egoist

yes

Copy link

@Akryum Akryum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably revert the unrelated changes such as package.json and pnpm-lock.yaml

I tried the fix and it's working great. 👍

@Akryum Akryum mentioned this pull request Jun 25, 2021
@liu-lihao
Copy link
Contributor Author

You should probably revert the unrelated changes such as package.json and pnpm-lock.yaml

I tried the fix and it's working great. 👍

Because I need build.initialOptions above 0.9.6

https://github.com/evanw/esbuild/blob/master/CHANGELOG.md#096

@egoist egoist merged commit d05d1f3 into egoist:main Jun 26, 2021
@github-actions
Copy link

🎉 This PR is included in version 0.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants