Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add tags when creating a cluster #150

Closed
richardcase opened this issue Aug 8, 2018 · 5 comments · Fixed by #186
Closed

Add tags when creating a cluster #150

richardcase opened this issue Aug 8, 2018 · 5 comments · Fixed by #186

Comments

@richardcase
Copy link
Contributor

It would be good if we can specify tags (i.e. key/value pairs) when creating a cluster.

Many companies use tags to help allocate costs between various teams and to drive other classification of services. For example, everything we deploy must have the following tags:

  • environment

  • owner

  • product

  • service

@jmcarp
Copy link
Contributor

jmcarp commented Sep 3, 2018

I was going to write up a patch for this, since we need tagging too, but it looks like there's a migration from aws-sdk-go to goformation in progress, so I figured I'd hold off. Does that make sense?

@richardcase
Copy link
Contributor Author

It does make sense to hold off for PR #132 to land first. A contribution for this would be great @jmcarp.

@richardcase
Copy link
Contributor Author

@jmcarp - the goformation change has landed in master if you fancied working on this? It might be worth following the kops naming convention:

--cloud-labels string A list of KV pairs used to tag all instance groups in AWS (eg "Owner=John Doe,Team=Some Team").

@errordeveloper - do you have any thoughts around tags on the created resources?

@errordeveloper
Copy link
Contributor

As of #132, it should be fairly easy to plumb custom tags through, see here:

https://github.com/weaveworks/eksctl/blob/f7a04d411d44a62705b7f06ad13e4ce70163e823/pkg/cfn/manager/api.go#L40-L42

Also, did you folks see #25?

@richardcase
Copy link
Contributor Author

I missed #25. So we could add tags for the CloudFormation stacks and then when the EKS API supports tags at that at a later date as a follow up issue?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants