Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rewrite relative local npm package.json dependencies to work when ins… #103

Conversation

mattsills
Copy link

…talled in the dist directory

@jdbevan
Copy link
Contributor

jdbevan commented Feb 16, 2017

It would be nice if there was some kind of automated test to go with this, but the code looks good and I need this fix too, so +1 :)

@HyperBrain HyperBrain mentioned this pull request Jun 30, 2017
@hassankhan
Copy link
Contributor

Is this still an issue? I've used relative paths for package dependencies in the past and don't remember having this problem.

@HyperBrain
Copy link
Member

@mattsills Could you please give an update (see @hassankhan 's question)? Please verify it with version 2.2.0.

@HyperBrain
Copy link
Member

I will close this PR now - there hasn't been any response for some weeks now. We should check if file: dependencies work in V3 and open a new issue if they do not. As the codebase has changed a completely new fix is appropriate then.

@HyperBrain HyperBrain closed this Aug 10, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants