Tidy README.md, fix nitpicks and add badges
#142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyperBrain
reviewed
Jul 2, 2017
| [](https://circleci.com/gh/elastic-coders/serverless-webpack) | ||
| [![Serverless][ico-serverless]][link-serverless] | ||
| [![CircleCI][ico-circleci]][link-circleci] | ||
| [![NPM][ico-npm]][link-npm] |
There was a problem hiding this comment.
Oops ... see my plugin for the source ;-)
There was a problem hiding this comment.
[](https://www.npmjs.com/package/serverless-webpack)
In general SVG render urls should be used.
There was a problem hiding this comment.
The icons are already SVG unless I'm mistaken... if you check the bottom of README.md:
[ico-serverless]: http://public.serverless.com/badges/v3.svg
[ico-circleci]: https://img.shields.io/circleci/project/github/elastic-coders/serverless-webpack.svg
[ico-npm]: https://img.shields.io/npm/v/serverless-webpack.svg
[ico-contributors]: https://img.shields.io/github/contributors/elastic-coders/serverless-webpack.svg
There was a problem hiding this comment.
;) Sorry ... did not read until the end.
HyperBrain
approved these changes
Jul 2, 2017
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #141
How did you implement it:
Updated
README.md.How can we verify it:
Viewing
README.md.Todos:
Write testsFix linting errors (not yet implemented)Make sure code coverage hasn't dropped (not yet implemented)Provide verification config / commands / resourcesIs this ready for review?: YES
Is it a breaking change?: NO