Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Pack external packages into distribution for deploy command and --out option #16

Merged
merged 6 commits into from
Aug 26, 2016

Conversation

cyyuen
Copy link
Contributor

@cyyuen cyyuen commented Aug 25, 2016

User could define custom key, includePackages to indicate which packages they want to pack into the final distribution:

custom:
   includePackages:
      - package1
      - package2

@thenikso
Copy link
Contributor

This is very cool! Would you have time to add an example in the examples and some lines in the readme?

@cyyuen
Copy link
Contributor Author

cyyuen commented Aug 26, 2016

Sure. @thenikso . I have added an example and some lines in readme. Could you help me to review it? Thanks.

@thenikso
Copy link
Contributor

thenikso commented Aug 26, 2016

Brilliant, it seams all well done to me. I tried it and it is a much needed addition.

My only concern would be the includePackages naming for the custom option not conveying the meaning. I'd think of adding "webpack" somewhere to connect the option with this plugin. Like webpackIncludePackages or webpackIncludeModules or webpackBundleModules what do you think? Not strongly opinionated on this, I'd like to avoid clashing with other plugins configurations tho.

I'll release 1.0.0-beta.2.2 when this is ready (I'll keep beta 3 for when the same Serverless beta is out).

Amazing work 🎉

@cyyuen
Copy link
Contributor Author

cyyuen commented Aug 26, 2016

I agree. I think webpackIncludeModules is the best.

@thenikso thenikso merged commit 26ba87c into serverless-heaven:master Aug 26, 2016
@thenikso
Copy link
Contributor

done 🎉 🎉 🎉

@cyyuen
Copy link
Contributor Author

cyyuen commented Aug 27, 2016

Awesome. Thanks! 🎉 🎉 🎉

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants