[Flaky Test] HTTPJSON input - TestMetrics/Test_pagination_metrics - expected non zero value for metric httpjson_interval_pages_execution_time

[belimawr]

Flaky Test

• Test Name: TestMetrics/Test_pagination_metrics
• Link:

  beats/x-pack/filebeat/input/httpjson/metrics_test.go

  Line 162 in 18a7e54

  assert.NoError(t, tc.assertMetrics(reg))

• Branch: https://github.com/belimawr/beats/tree/log-raw-events-to-file-v2
• Artifact Link: https://buildkite.com/elastic/beats-xpack-filebeat/builds/2875#018f9bdc-bdc8-498f-b59a-20b57edaa95b/134-509
• Notes:
  The test if flaky on Windows, running go test -run=TestMetrics -count=10 -v ./input/httpjson from x-pack/filebeat was enough to consistently have the test failing at least once. It does not fail/reproduce on Linux, even with 3000 repetitions there was no failure. My PR is only changing logging, I don't see how it could have affected the metrics from this input/this test.

Stack Trace

2024-05-21 12:10:23 EDT	=== Failed
2024-05-21 12:10:23 EDT	=== FAIL: x-pack/filebeat/input/httpjson TestMetrics/Test_pagination_metrics (0.02s)
2024-05-21 12:10:23 EDT	    metrics_test.go:162:
2024-05-21 12:10:23 EDT	        	Error Trace:	C:/buildkite-agent/builds/bk-agent-prod-gcp-1716306902497376129/elastic/beats-xpack-filebeat/x-pack/filebeat/input/httpjson/metrics_test.go:162
2024-05-21 12:10:23 EDT	        	Error:      	Received unexpected error:
2024-05-21 12:10:23 EDT	        	            	expected non zero value for metric httpjson_interval_pages_execution_time
2024-05-21 12:10:23 EDT	        	Test:       	TestMetrics/Test_pagination_metrics
2024-05-21 12:10:23 EDT	
2024-05-21 12:10:23 EDT	=== FAIL: x-pack/filebeat/input/httpjson TestMetrics (0.02s)

[elasticmachine]

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

[belimawr]

It's also failing on main (18a7e5447a3b474f3f09f98932ff124d210067a5):

PS C:\devel\beats\x-pack\filebeat> go test -v -count=10 -run=TestMetrics .\input\httpjson\
go: downloading github.com/elastic/elastic-agent-libs v0.9.8
go: downloading github.com/elastic/elastic-agent-client/v7 v7.9.0
=== RUN   TestMetrics
=== RUN   TestMetrics/Test_pagination_metrics
--- PASS: TestMetrics (0.06s)
    --- PASS: TestMetrics/Test_pagination_metrics (0.06s)
=== RUN   TestMetrics
=== RUN   TestMetrics/Test_pagination_metrics
--- PASS: TestMetrics (0.03s)
    --- PASS: TestMetrics/Test_pagination_metrics (0.03s)
=== RUN   TestMetrics
=== RUN   TestMetrics/Test_pagination_metrics
--- PASS: TestMetrics (0.04s)
    --- PASS: TestMetrics/Test_pagination_metrics (0.04s)
=== RUN   TestMetrics
=== RUN   TestMetrics/Test_pagination_metrics
--- PASS: TestMetrics (0.06s)
    --- PASS: TestMetrics/Test_pagination_metrics (0.06s)
=== RUN   TestMetrics
=== RUN   TestMetrics/Test_pagination_metrics
    metrics_test.go:162:
                Error Trace:    C:/devel/beats/x-pack/filebeat/input/httpjson/metrics_test.go:162
                Error:          Received unexpected error:
                                expected non zero value for metric httpjson_interval_pages_execution_time
                Test:           TestMetrics/Test_pagination_metrics
--- FAIL: TestMetrics (0.05s)
    --- FAIL: TestMetrics/Test_pagination_metrics (0.05s)
=== RUN   TestMetrics
=== RUN   TestMetrics/Test_pagination_metrics
--- PASS: TestMetrics (0.05s)
    --- PASS: TestMetrics/Test_pagination_metrics (0.05s)
=== RUN   TestMetrics
=== RUN   TestMetrics/Test_pagination_metrics
--- PASS: TestMetrics (0.04s)
    --- PASS: TestMetrics/Test_pagination_metrics (0.04s)
=== RUN   TestMetrics
=== RUN   TestMetrics/Test_pagination_metrics
--- PASS: TestMetrics (0.05s)
    --- PASS: TestMetrics/Test_pagination_metrics (0.05s)
=== RUN   TestMetrics
=== RUN   TestMetrics/Test_pagination_metrics
--- PASS: TestMetrics (0.06s)
    --- PASS: TestMetrics/Test_pagination_metrics (0.06s)
=== RUN   TestMetrics
=== RUN   TestMetrics/Test_pagination_metrics
--- PASS: TestMetrics (0.03s)
    --- PASS: TestMetrics/Test_pagination_metrics (0.03s)
FAIL
FAIL    github.com/elastic/beats/v7/x-pack/filebeat/input/httpjson      0.551s
FAIL
PS C:\devel\beats\x-pack\filebeat>

[efd6]

Putting together a windows skip now.

[belimawr]

Putting together a windows skip now.

Thanks, I was about to do it.